RE: [PATCH 1/2] pinmux: Remove double pin validity check.

[Stephen Warren <swarren@nvidia.com>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1474 bytes --]

Belisko Marek wrote at Thursday, October 27, 2011 12:40 PM:
> On Thu, Oct 27, 2011 at 6:37 PM, Stephen Warren <swarren@nvidia.com> wrote:
> > Belisko Marek wrote at Wednesday, October 26, 2011 2:57 PM:
> >> Function pin_is_valid just call pin_desc_get which is in pin_request
> >> call some line below. Remove pin_is_valid() check.
> > ...
> >> @@ -112,16 +112,6 @@ static int pin_request(struct pinctrl_dev *pctldev,
> >>
> >>       dev_dbg(&pctldev->dev, "request pin %d for %s\n", pin, function);
> >>
> >> -     if (!pin_is_valid(pctldev, pin)) {
> >> -             dev_err(&pctldev->dev, "pin is invalid\n");
> >> -             return -EINVAL;
> >> -     }
> >
> > So that makes sense.
> >
> >> -
> >> -     if (!function) {
> >> -             dev_err(&pctldev->dev, "no function name given\n");
> >> -             return -EINVAL;
> >> -     }
> >
> > But I don't think you want to remove that? Oh actually, perhaps removing
> > that /is/ valid, since it's an internal function and can't be called with
> > a NULL function parameter. But, you should mention why in the changelog
> > so it doesn't look like a mistake.
>
> Well it's not removed. It's moved below pin_desc_get call.

Sigh, so it is. In that case,

Acked-by: Stephen Warren <swarren@nvidia.com>

-- 
nvpublic

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥