From: Stephen Warren <swarren@nvidia.com>
To: Taylor Hutt <thutt@chromium.org>
Cc: "miletus@chromium.org" <miletus@chromium.org>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: RE: [PATCH] ASoc : Tegra : Add audio map for Asymptote
Date: Tue, 1 Nov 2011 09:55:59 -0700 [thread overview]
Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF173EDABA51@HQMAIL01.nvidia.com> (raw)
In-Reply-To: <1320165173-3951-1-git-send-email-thutt@chromium.org>
Taylor Hutt wrote at Tuesday, November 01, 2011 10:33 AM:
> Details
>
> Add pin connections and audio map for the Asymptote board.
>
> Testing
>
> Visual inspection with Chromium OS 2.6.38 code.
> Built kernel
> Built chromium os image
> Booted image on asymptote
> Booted image on kaen
Presumably all that testing was within the chromeos-3.0 kernel, not
mainline; asymptote isn't supported in mainline.
This patch can't be applied for a few reasons:
a) Asymptote isn't in mainline's arch/arm/tools/mach-types. This means
that function machine_is_asymptote() doesn't exists, and this code can't
compile.
b) Even if the machine were in mach-types, there's no board file for
asymptote, so Russell King's automated mach-types cleanup script would
flag asymptote for removal and eventually it'd go away. This is the same
reason we recently removed Ventana support from tegra_wm8903.c. I'm not
sure how this will work once we have device-tree-only boards; I guess
we need to remove all the machine_is_foo() checks from the code and
parameterize everything from DT instead.
--
nvpublic
prev parent reply other threads:[~2011-11-01 16:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-01 16:32 Taylor Hutt
2011-11-01 16:55 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74CDBE0F657A3D45AFBB94109FB122FF173EDABA51@HQMAIL01.nvidia.com \
--to=swarren@nvidia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=miletus@chromium.org \
--cc=perex@perex.cz \
--cc=thutt@chromium.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®