From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933334Ab1KBQIH (ORCPT ); Wed, 2 Nov 2011 12:08:07 -0400 Received: from hqemgate03.nvidia.com ([216.228.121.140]:5407 "EHLO hqemgate03.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932383Ab1KBQIF convert rfc822-to-8bit (ORCPT ); Wed, 2 Nov 2011 12:08:05 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Wed, 02 Nov 2011 09:07:53 -0700 From: Stephen Warren To: Peter De Schrijver , Russell King , Colin Cross , Olof Johansson , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-tegra@vger.kernel.org" Date: Wed, 2 Nov 2011 09:07:52 -0700 Subject: RE: [PATCH v2 8/8] arm/tegra: add support for tegra30 based board cardhu Thread-Topic: [PATCH v2 8/8] arm/tegra: add support for tegra30 based board cardhu Thread-Index: AcyZdo5ETdQN3/r0Q7S1bsyQlxV5PAAAsmXQ Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF173F9A46C4@HQMAIL01.nvidia.com> References: <1320242948-21061-1-git-send-email-pdeschrijver@nvidia.com> <1320242948-21061-9-git-send-email-pdeschrijver@nvidia.com> <20111102154610.GJ13358@tbergstrom-lnx.Nvidia.com> In-Reply-To: <20111102154610.GJ13358@tbergstrom-lnx.Nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Peter De Schrijver wrote at Wednesday, November 02, 2011 9:46 AM: > On Wed, Nov 02, 2011 at 03:09:07PM +0100, Peter De Schrijver wrote: > > Add support for the tegra30 based cardhu development board. Cardhu is a tablet > > formfactor reference design for tegra30. The patch provides a device tree for > > the board, updates Makefile.boot to build the dtb, includes the platform in > > Kconfig and updates board-dt.c. ... > > diff --git a/arch/arm/boot/dts/tegra-cardhu.dts b/arch/arm/boot/dts/tegra-cardhu.dts > > new file mode 100644 > > index 0000000..70c41fc > > --- /dev/null > > +++ b/arch/arm/boot/dts/tegra-cardhu.dts > > @@ -0,0 +1,36 @@ > > +/dts-v1/; > > + > > +/include/ "tegra30.dtsi" > > + > > +/ { > > + model = "NVIDIA Tegra30 Cardhu evaluation board"; > > And this should probably be removed. I don't follow the reasoning here; it seems correct to identify what this .dts file applies to, and having a model property is consistent with other .dts files, including non-Tegra boards. -- nvpublic