From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754327Ab1KUXjh (ORCPT ); Mon, 21 Nov 2011 18:39:37 -0500 Received: from hqemgate03.nvidia.com ([216.228.121.140]:8895 "EHLO hqemgate03.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751373Ab1KUXjg convert rfc822-to-8bit (ORCPT ); Mon, 21 Nov 2011 18:39:36 -0500 X-PGP-Universal: processed; by hqnvupgp05.nvidia.com on Mon, 21 Nov 2011 15:39:34 -0800 From: Stephen Warren To: Denis Kuzmenko CC: "linux-kernel@vger.kernel.org" , Grant Likely , Linus Walleij , Richard Purdie , Wolfram Sang Date: Mon, 21 Nov 2011 15:39:32 -0800 Subject: RE: [PATCH] s3c/s3c24xx: arm: leds: Make s3c24xx LEDS driver use gpiolib Thread-Topic: [PATCH] s3c/s3c24xx: arm: leds: Make s3c24xx LEDS driver use gpiolib Thread-Index: Acyon+fPvxJpJjdKTO+5DuXO6gGr+wABqoYA Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF174F08C2B4@HQMAIL01.nvidia.com> References: <4EC572E1.1020209@solonet.org.ua> <74CDBE0F657A3D45AFBB94109FB122FF1740D74E87@HQMAIL01.nvidia.com> <4EC6C785.5010801@solonet.org.ua> <4EC6D1D5.9060808@solonet.org.ua> <74CDBE0F657A3D45AFBB94109FB122FF1740D74FAD@HQMAIL01.nvidia.com> <4EC6DD8F.9070904@solonet.org.ua> <74CDBE0F657A3D45AFBB94109FB122FF1740D74FE6@HQMAIL01.nvidia.com> <4EC6E75E.2080200@solonet.org.ua> <74CDBE0F657A3D45AFBB94109FB122FF174F08C135@HQMAIL01.nvidia.com> <4ECAA894.4050500@solonet.org.ua> <74CDBE0F657A3D45AFBB94109FB122FF174F08C246@HQMAIL01.nvidia.com> <4ECAD613.3030605@solonet.org.ua> In-Reply-To: <4ECAD613.3030605@solonet.org.ua> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Denis Kuzmenko wrote at Monday, November 21, 2011 3:52 PM: ... > > I don't see any pulls being configured in the original code at all, > > unless some of the s3c2410_* function have unexpected side-effect. The > > only related thing is in probe: > > > > /* no point in having a pull-up if we are always driving */ > > > > if (pdata->flags & S3C24XX_LEDF_TRISTATE) { > > .. > > } else { > > s3c2410_gpio_pullup(pdata->gpio, 0); > > > > which I assume disables an pull in the case where the pin is always driven. > > > > So, yes, I'd say submit v3 without any pull manipulation at all. > > > > Actually, "s3c2410_gpio_pullup(pdata->gpio, 0);" enables pull in the > same way I've done that. Here is it's code: So it does. That's extremely non-obvious if not broken. Anyway, I guess that means that your patch V1 is at least a pure conversion of the code from custom functions to gpiolib, even if what it was and still is doing doesn't make much sense to me. -- nvpublic