From: Stephen Warren <swarren@nvidia.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rakesh Iyer <riyer@nvidia.com>
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/1] Input: tegra-kbc - remove pre Tegra20 definitions
Date: Wed, 18 Jan 2012 08:36:26 -0800 [thread overview]
Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF1780DAADCB@HQMAIL01.nvidia.com> (raw)
In-Reply-To: <20120118003012.GA27489@core.coreip.homeip.net>
Dmitry Torokhov wrote at Tuesday, January 17, 2012 5:30 PM:
> On Tue, Jan 17, 2012 at 03:26:50PM -0800, Rakesh Iyer wrote:
> > Add support for Tegra30 by correcting definitions. This is necessary to
> > make driver useful in Tegra30.
>
> So what about older versions? There still could be users...
I wonder if there will be problems with this patch; the loop in
tegra_kbc_report_keys() is going to process 8 bits more of the last
register and the loop in tegra_kbc_config_pins() will now touch one
more row and one more column register. I think these loops should be
limited at run-time based on the SoC actually being executed upon?
--
nvpublic
next prev parent reply other threads:[~2012-01-18 16:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-17 23:26 Rakesh Iyer
2012-01-18 0:30 ` Dmitry Torokhov
2012-01-18 16:36 ` Stephen Warren [this message]
2012-01-18 21:12 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74CDBE0F657A3D45AFBB94109FB122FF1780DAADCB@HQMAIL01.nvidia.com \
--to=swarren@nvidia.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riyer@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®