From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751475AbeA2HKo (ORCPT ); Mon, 29 Jan 2018 02:10:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36122 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751042AbeA2HKn (ORCPT ); Mon, 29 Jan 2018 02:10:43 -0500 Subject: Re: [PATCH net-next 00/12] ptr_ring fixes To: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org Cc: netdev@vger.kernel.org, John Fastabend , David Miller References: <1516923320-16959-1-git-send-email-mst@redhat.com> From: Jason Wang Message-ID: <74a2d464-3b3c-94fc-bf05-dee8e7ae775c@redhat.com> Date: Mon, 29 Jan 2018 15:10:37 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1516923320-16959-1-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018年01月26日 07:36, Michael S. Tsirkin wrote: > This fixes a bunch of issues around ptr_ring use in net core. > One of these: "tap: fix use-after-free" is also needed on net, > but can't be backported cleanly. > > I will post a net patch separately. > > Lightly tested - Jason, could you pls confirm this > addresses the security issue you saw with ptr_ring? > Testing reports would be appreciated too. > > Michael S. Tsirkin (12): > ptr_ring: keep consumer_head valid at all times > ptr_ring: clean up documentation > ptr_ring: READ/WRITE_ONCE for __ptr_ring_empty > tap: fix use-after-free > ptr_ring: disallow lockless __ptr_ring_full > Revert "net: ptr_ring: otherwise safe empty checks can overrun array > bounds" > skb_array: use __ptr_ring_empty > ptr_ring: prevent queue load/store tearing > tools/virtio: switch to __ptr_ring_empty > tools/virtio: more stubs to fix tools build > tools/virtio: copy READ/WRITE_ONCE > tools/virtio: fix smp_mb on x86 > > drivers/net/tap.c | 3 -- > include/linux/ptr_ring.h | 86 ++++++++++++++++++++++------------------ > include/linux/skb_array.h | 2 +- > tools/virtio/linux/kernel.h | 2 +- > tools/virtio/linux/thread_info.h | 1 + > tools/virtio/ringtest/main.h | 59 ++++++++++++++++++++++++++- > tools/virtio/ringtest/ptr_ring.c | 2 +- > 7 files changed, 110 insertions(+), 45 deletions(-) > create mode 100644 tools/virtio/linux/thread_info.h > For the series: Tested-by: Jason Wang Acked-by: Jason Wang Thanks