Re: [RESEND][PATCH 5/8] PM: EM: Remove old debugfs files and print all 'flags'

mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed

From: Lukasz Luba <lukasz.luba@arm.com>
To: Ionela Voinescu <ionela.voinescu@arm.com>
Cc: linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com,
	Pierre.Gondois@arm.com, viresh.kumar@linaro.org,
	rafael@kernel.org, daniel.lezcano@linaro.org,
	linux-pm@vger.kernel.org, mka@chromium.org, nm@ti.com,
	sboyd@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, cristian.marussi@arm.com,
	sudeep.holla@arm.com, matthias.bgg@gmail.com
Subject: Re: [RESEND][PATCH 5/8] PM: EM: Remove old debugfs files and print all 'flags'
Date: Mon, 4 Apr 2022 17:31:02 +0100	[thread overview]
Message-ID: <74a2f038-50dd-91e5-227d-a1c633a87184@arm.com> (raw)
In-Reply-To: <YksWj8GhZWUimF74@arm.com>

Hi Ionela,

Thank you for reviewing these patches.

On 4/4/22 17:02, Ionela Voinescu wrote:
> Hi Lukasz,
> 
> IMO the debugfs files were fine as they were:
>   - They offered information on units and inefficiencies without having
>     to dig into the code to see which bit is for which flag.
>   - I believe the artificial EM power values fit under bogoWatts as unit,
>     so that part would still be correct.
> 
> On the other hand, your new file offers more information: we'd be able
> to see in debugfs whether we're dealing with an artificial EM, despite
> needing a bit more looking over the code to understand the output.

I have consolidated them, so we would support more features in the flag
automatically when there will be a need.

In Android kernel we don't have unfortunately the debugfs compiled-in,
so this information is still only for kernel testing with some Linux
distro.

I have been thinking to switch into sysfs interface, so we could
have it in Android as well. This patch change adding a generic 'flags'
which would be more 'stable' (which is a requirement for sysfs contract)
is also a closer step into that direction. But that is for longer
discussion and not for this $subject.

> 
> I don't have a strong opinion and the code looks fine, so:
> 
> Reviewed-by: Ionela Voinescu <ionela.voinescu@arm.com>
>

next prev parent reply	other threads:[~2022-04-04 21:59 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-21  9:57 [RESEND][PATCH 0/8] Introduce support for artificial Energy Model Lukasz Luba
2022-03-21  9:57 ` [RESEND][PATCH 1/8] PM: EM: Add .get_cost() callback Lukasz Luba
2022-04-04 16:00   ` Ionela Voinescu
2022-03-21  9:57 ` [RESEND][PATCH 2/8] PM: EM: Add artificial EM flag Lukasz Luba
2022-04-04 16:01   ` Ionela Voinescu
2022-03-21  9:57 ` [RESEND][PATCH 3/8] PM: EM: Use the new .get_cost() callback while registering EM Lukasz Luba
2022-04-04 16:01   ` Ionela Voinescu
2022-03-21  9:57 ` [RESEND][PATCH 4/8] PM: EM: Change the order of arguments in the .active_power() callback Lukasz Luba
2022-04-04 16:02   ` Ionela Voinescu
2022-03-21  9:57 ` [RESEND][PATCH 5/8] PM: EM: Remove old debugfs files and print all 'flags' Lukasz Luba
2022-04-04 16:02   ` Ionela Voinescu
2022-04-04 16:31     ` Lukasz Luba [this message]
2022-03-21  9:57 ` [RESEND][PATCH 6/8] Documentation: EM: Add artificial EM registration description Lukasz Luba
2022-04-04 16:02   ` Ionela Voinescu
2022-03-21  9:57 ` [RESEND][PATCH 7/8] thermal: cooling: Check Energy Model type in cpufreq_cooling and devfreq_cooling Lukasz Luba
2022-03-28  3:27   ` Viresh Kumar
2022-03-29  6:37     ` Lukasz Luba
2022-04-04 16:02   ` Ionela Voinescu
2022-03-21  9:57 ` [RESEND][PATCH 8/8] powercap: DTPM: Check for Energy Model type Lukasz Luba
2022-04-04 16:03   ` Ionela Voinescu
2022-04-04 12:35 ` [RESEND][PATCH 0/8] Introduce support for artificial Energy Model Lukasz Luba
2022-04-12  6:53   ` Lukasz Luba
2022-04-13 14:29     ` Rafael J. Wysocki
2022-04-13 14:47       ` Lukasz Luba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74a2f038-50dd-91e5-227d-a1c633a87184@arm.com \
    --to=lukasz.luba@arm.com \
    --cc=Pierre.Gondois@arm.com \
    --cc=cristian.marussi@arm.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=ionela.voinescu@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=mka@chromium.org \
    --cc=nm@ti.com \
    --cc=rafael@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®