From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753045AbbBKOZb (ORCPT ); Wed, 11 Feb 2015 09:25:31 -0500 Received: from mail-bn1on0091.outbound.protection.outlook.com ([157.56.110.91]:64774 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752473AbbBKOZ3 (ORCPT ); Wed, 11 Feb 2015 09:25:29 -0500 Date: Wed, 11 Feb 2015 15:25:02 +0100 From: Michal Simek User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Mark Rutland , Michal Simek CC: "linux-arm-kernel@lists.infradead.org" , "monstr@monstr.eu" , Josh Cartwright , Steffen Trumtrar , Rob Herring , Peter Crosthwaite , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Russell King , =?windows-1252?Q?S=F6ren_Brinkmann?= , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/2] ARM: dts: zynq: Add linux,stdout-path and stdout-path References: <0a0e0579fb6e2794d2c0c6fb9186c5b43618f448.1423657710.git.michal.simek@xilinx.com> <20150211124027.GH9154@leverpostej> In-Reply-To: <20150211124027.GH9154@leverpostej> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-7.5.0.1018-21296.000 X-TM-AS-User-Approved-Sender: Yes Message-ID: <74a9cc5d88d64421a4f1ebdacee93d7d@BL2FFO11FD041.protection.gbl> X-EOPAttributedMessage: 0 Authentication-Results: spf=pass (sender IP is 62.221.5.235) smtp.mailfrom=michal.simek@xilinx.com; arm.com; dkim=none (message not signed) header.d=none; X-Forefront-Antispam-Report: CIP:62.221.5.235;CTRY:GB;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(438002)(377454003)(51704005)(164054003)(24454002)(479174004)(64126003)(74316001)(50986999)(19580395003)(19580405001)(83506001)(54356999)(575784001)(86362001)(6806004)(23746002)(65806001)(108616004)(76176999)(87936001)(92566002)(62966003)(2950100001)(92726002)(104016003)(47776003)(65956001)(106466001)(77096005)(77156002)(50466002)(46102003)(65826006)(107986001)(142933001)(24736002);DIR:OUT;SFP:1101;SCL:1;SRVR:BL2FFO11HUB011;H:xir-pvapsmtpgw01;FPR:;SPF:Pass;MLV:sfv;LANG:en; X-Microsoft-Antispam: UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:BL2FFO11HUB011; X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004);SRVR:BL2FFO11HUB011; X-Forefront-PRVS: 0484063412 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:;SRVR:BL2FFO11HUB011; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2015 14:25:25.8257 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[62.221.5.235] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2FFO11HUB011 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/11/2015 01:40 PM, Mark Rutland wrote: > On Wed, Feb 11, 2015 at 12:29:02PM +0000, Michal Simek wrote: >> parallella - Use reference instead of hardcoded path >> (linux,stdout-path) >> >> stdout-path is used by bootloader to identify console. >> >> Signed-off-by: Michal Simek >> --- >> >> U-Boot driver model requires stdout-path. >> --- >> arch/arm/boot/dts/zynq-parallella.dts | 3 ++- >> arch/arm/boot/dts/zynq-zc702.dts | 2 ++ >> arch/arm/boot/dts/zynq-zc706.dts | 2 ++ >> arch/arm/boot/dts/zynq-zed.dts | 2 ++ >> arch/arm/boot/dts/zynq-zybo.dts | 2 ++ >> 5 files changed, 10 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/zynq-parallella.dts b/arch/arm/boot/dts/zynq-parallella.dts >> index 6a5f51daa708..45228a427006 100644 >> --- a/arch/arm/boot/dts/zynq-parallella.dts >> +++ b/arch/arm/boot/dts/zynq-parallella.dts >> @@ -35,7 +35,8 @@ >> >> chosen { >> bootargs = "console=ttyPS0,115200 earlyprintk root=/dev/mmcblk0p2 rootfstype=ext4 rw rootwait"; >> - linux,stdout-path = "/amba/serial@e0001000"; >> + linux,stdout-path = &uart1; >> + stdout-path = &uart1; > > Given that you added aliases in the last patch, you can use that to > refer to the serial: > > stdout-path - "serial0:115200n8"; > > With or without the alias you can encode the UART configuration here > too: > > stdout-path = "/amba/serial@e0001000:115200n8" let me check this configuration if it is supported by u-boot. > > Which makes the expected configuration explicit without relying on the > Linux-specific bootargs. > > Is there any reason to keep linux,stdout-path? Agree when stdout-patch is defined there is no reason to use linux,stdout-patch. Thanks, Michal