From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B4C2EB64D9 for ; Mon, 10 Jul 2023 10:19:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233426AbjGJKTz (ORCPT ); Mon, 10 Jul 2023 06:19:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233407AbjGJKTg (ORCPT ); Mon, 10 Jul 2023 06:19:36 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 350C31FF0 for ; Mon, 10 Jul 2023 03:18:54 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2b6fbf0c0e2so64784541fa.2 for ; Mon, 10 Jul 2023 03:18:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688984332; x=1691576332; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=i4Yt6jByRQ8UFPjX+QYfSMRSiYEbxoGiK3g/FogftK4=; b=THOJ5lDTIAUv0g6+hdYNtFZRmpZ1sOsItEI3uZB1UXDsad7VTCTUASzaDP8kW6KAGE ZWeEaFdZpsYp5gHypo4Cf+0EFlHchlY9Ng9mbtRveFej3AJKOe1Ijx5KwluyDsKU/Smh LFnJRvw5k19jN8U/grLbJEE3C0R2Tr0XIdbQfy9ROMI8IBxq78D+RyNqhg7HsnPKmCYZ vHdC/qVnvQ1HG7gl0ZouzyT6liyAH+7G2TLvp3rjUzhaoxVJgGhJ2dPrOVIXY1OlZkh9 e3p88udGpEFFv1AMFgozqbwO95OrCYoLVmPds4wBglkn1PmdUVKah6zLB2pXadVVZ/R3 1G0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688984332; x=1691576332; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=i4Yt6jByRQ8UFPjX+QYfSMRSiYEbxoGiK3g/FogftK4=; b=WATeX2Ixo2BV68mEPqK1phEFboyKaxJqRas3DlXbHdHMHyQ0EBsW/tKDUk5TXtJN3Y e6BCOdChnb1k4Yf+eZnf7buS25I9ibm65aXVqFRJ2N/5qhGGi/NxULpdtboQHBptvC32 KO2zGMaYUZqIoLs5nZNvR0U/oOJg2ulbty5zzsDiLak+Xa1uZ9mq6ZQPFQxNosK2jx0u CcWAu/GCe0VAGaV6Eu/o7W5rKTO5Eub74f4OmUZ7sho2TsdFf3K4gQYuaNPJ0qR48DKf zKR1NgkUoSA+cFrlfpyg6a+lCLyeA9NoJhPSVvQCHSinseLTdV2ecESOjhk3+7CcidPN ECcg== X-Gm-Message-State: ABy/qLaLuZ1uqp4jq8m+bcOvei2beR0DdXed2EV8omWYP82XfrD/fKtw 0R9Jza60V+h2b43utEVyTxczAU4NlUSY3HZoSg3aYA== X-Google-Smtp-Source: APBJJlGcqkp5rqwlLnxdIkdWpmebSjbzBOnq/8Gzu2xJq62n8aShR/Rwsgt6EBSo80iaOQjXU74kqA== X-Received: by 2002:a2e:b781:0:b0:2b7:7b9:4767 with SMTP id n1-20020a2eb781000000b002b707b94767mr8820763ljo.41.1688983473701; Mon, 10 Jul 2023 03:04:33 -0700 (PDT) Received: from [192.168.1.101] (abxj141.neoplus.adsl.tpnet.pl. [83.9.3.141]) by smtp.gmail.com with ESMTPSA id p1-20020a2ea401000000b002b6c92fa161sm1866277ljn.61.2023.07.10.03.04.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Jul 2023 03:04:33 -0700 (PDT) Message-ID: <74aa7196-e76c-a1c8-9b0f-1d5f236d3467@linaro.org> Date: Mon, 10 Jul 2023 12:04:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 2/2] usb: typec: qcom-pmic-typec: register drm_bridge To: Bryan O'Donoghue , Dmitry Baryshkov , Heikki Krogerus , Greg Kroah-Hartman , Guenter Roeck , Andy Gross , Bjorn Andersson Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20230709201309.274306-1-dmitry.baryshkov@linaro.org> <20230709201309.274306-3-dmitry.baryshkov@linaro.org> <0408a6f6-356e-af6a-3e32-1781aec2854f@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <0408a6f6-356e-af6a-3e32-1781aec2854f@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10.07.2023 12:02, Bryan O'Donoghue wrote: > On 09/07/2023 21:13, Dmitry Baryshkov wrote: >> The current approach to handling DP on bridge-enabled platforms requires >> a chain of DP bridges up to the USB-C connector. Register a last DRM >> bridge for such chain. >> >> Signed-off-by: Dmitry Baryshkov >> --- >>   drivers/usb/typec/tcpm/Kconfig                |  1 + >>   drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c | 39 +++++++++++++++++++ >>   2 files changed, 40 insertions(+) >> >> diff --git a/drivers/usb/typec/tcpm/Kconfig b/drivers/usb/typec/tcpm/Kconfig >> index 5d393f520fc2..0b2993fef564 100644 >> --- a/drivers/usb/typec/tcpm/Kconfig >> +++ b/drivers/usb/typec/tcpm/Kconfig >> @@ -79,6 +79,7 @@ config TYPEC_WCOVE >>   config TYPEC_QCOM_PMIC >>       tristate "Qualcomm PMIC USB Type-C Port Controller Manager driver" >>       depends on ARCH_QCOM || COMPILE_TEST >> +    depends on DRM || DRM=n >>       help >>         A Type-C port and Power Delivery driver which aggregates two >>         discrete pieces of silicon in the PM8150b PMIC block: the >> diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c >> index a905160dd860..0722fb8d75c4 100644 >> --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c >> +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c >> @@ -17,6 +17,9 @@ >>   #include >>   #include >>   #include >> + >> +#include >> + >>   #include "qcom_pmic_typec_pdphy.h" >>   #include "qcom_pmic_typec_port.h" >>   @@ -33,6 +36,9 @@ struct pmic_typec { >>       struct pmic_typec_port    *pmic_typec_port; >>       bool            vbus_enabled; >>       struct mutex        lock;        /* VBUS state serialization */ >> +#ifdef CONFIG_DRM >> +    struct drm_bridge    bridge; >> +#endif > > IMO there's no reason to ifdef the structure. Its up to you if you want to change it nor not, I have no strong feelings about it. +1, there's no ifdefs in the drm_bridge.h header that would make this not compile Konrad > > Acked-by: Bryan O'Donoghue > > --- > bod