From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Kevin Tung <kevin.tung.openbmc@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Amithash Prasasd <amithash@meta.com>,
Kevin Tung <Kevin.Tung@quantatw.com>,
Ken Chen <Ken.Chen@quantatw.com>,
Leo Yang <Leo-Yang@quantatw.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Joel Stanley <joel@jms.id.au>
Subject: Re: [PATCH 3/3] ARM: dts: aspeed: yosemite5: Rename sgpio P0_I3C_APML_ALERT_L
Date: Mon, 24 Nov 2025 15:14:21 +1030 [thread overview]
Message-ID: <74b9c09cebac1de0e6e2e712a1374ab5294f61d8.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20251118-yv5_revise_dts-v1-3-fcd6b44b4497@gmail.com>
On Tue, 2025-11-18 at 18:53 +0800, Kevin Tung wrote:
> Rename P0_I3C_APML_ALERT_L to FM_APML_CPU_ALERT_N for clarity.
Are user space components looking for these names? Will updating the
devicetree break older applications? I'd like to see more discussion of
these problems in the commit message.
Cheers,
Andrew
>
> Signed-off-by: Kevin Tung <kevin.tung.openbmc@gmail.com>
> ---
> arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> index 45b8ac2e8c65a4f672e64571631b7f6944f26213..060757b7211a6da777c51d9f0c886796cf2450a4 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> @@ -964,7 +964,7 @@ &sgpiom0 {
> "FAULT_P3V3_NIC_N","",
> "FAULT_P12V_NIC_N","",
> "FAULT_P12V_SCM_N","",
> - "P0_I3C_APML_ALERT_L","",
> + "FM_APML_CPU_ALERT_N","",
> "ALERT_INLET_TEMP_N","",
> "FM_CPU_PROCHOT_R_N","",
> "FM_CPU_THERMTRIP_N","",
next prev parent reply other threads:[~2025-11-24 4:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 10:53 [PATCH 0/3] Revise Meta Yosemite5 devicetree Kevin Tung
2025-11-18 10:53 ` [PATCH 1/3] ARM: dts: aspeed: yosemite5: Increase i2c4/i2c12 bus speed to 400 kHz Kevin Tung
2025-11-18 10:53 ` [PATCH 2/3] ARM: dts: aspeed: yosemite5: Update sensor configuration Kevin Tung
2025-11-24 4:42 ` Andrew Jeffery
2025-12-19 8:36 ` Kevin Tung
2025-11-18 10:53 ` [PATCH 3/3] ARM: dts: aspeed: yosemite5: Rename sgpio P0_I3C_APML_ALERT_L Kevin Tung
2025-11-24 4:44 ` Andrew Jeffery [this message]
2025-12-19 8:26 ` Kevin Tung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74b9c09cebac1de0e6e2e712a1374ab5294f61d8.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=Ken.Chen@quantatw.com \
--cc=Kevin.Tung@quantatw.com \
--cc=Leo-Yang@quantatw.com \
--cc=amithash@meta.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=kevin.tung.openbmc@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®