From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Svyatoslav Ryhel <clamor95@gmail.com>
Cc: Iskren Chernev <me@iskren.info>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Matheus Castello <matheus@castello.eng.br>,
Sebastian Reichel <sre@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 4/4] power: max17040: get thermal data from adc if available
Date: Wed, 8 Mar 2023 11:46:05 +0100 [thread overview]
Message-ID: <74ba115e-9838-4983-7b93-188a8260dd8a@linaro.org> (raw)
In-Reply-To: <CAPVz0n0DNpn7uO+2X9QREpdc51R--ogsLSXWTyL1TybDsO2GvQ@mail.gmail.com>
On 08/03/2023 10:23, Svyatoslav Ryhel wrote:
> ср, 8 бер. 2023 р. о 11:08 Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> пише:
>>
>> On 08/03/2023 09:44, Svyatoslav Ryhel wrote:
>>> Since fuel gauge does not support thermal monitoring,
>>> some vendors may couple this fuel gauge with thermal/adc
>>> sensor to monitor battery cell exact temperature.
>>>
>>> Add this feature by adding optional iio thermal channel.
>>>
>>> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
>>> ---
>>> drivers/power/supply/max17040_battery.c | 24 ++++++++++++++++++++++++
>>> 1 file changed, 24 insertions(+)
>>>
>>> diff --git a/drivers/power/supply/max17040_battery.c b/drivers/power/supply/max17040_battery.c
>>> index 6dfce7b1309e..8c743c26dc6e 100644
>>> --- a/drivers/power/supply/max17040_battery.c
>>> +++ b/drivers/power/supply/max17040_battery.c
>>> @@ -18,6 +18,7 @@
>>> #include <linux/of_device.h>
>>> #include <linux/regmap.h>
>>> #include <linux/slab.h>
>>> +#include <linux/iio/consumer.h>
>>>
>>> #define MAX17040_VCELL 0x02
>>> #define MAX17040_SOC 0x04
>>> @@ -143,6 +144,7 @@ struct max17040_chip {
>>> struct power_supply *battery;
>>> struct power_supply_battery_info *batt_info;
>>> struct chip_data data;
>>> + struct iio_channel *channel_temp;
>>>
>>> /* battery capacity */
>>> int soc;
>>> @@ -416,6 +418,11 @@ static int max17040_get_property(struct power_supply *psy,
>>> case POWER_SUPPLY_PROP_CHARGE_FULL_DESIGN:
>>> val->intval = chip->batt_info->charge_full_design_uah;
>>> break;
>>> + case POWER_SUPPLY_PROP_TEMP:
>>> + iio_read_channel_raw(chip->channel_temp,
>>> + &val->intval);
>>> + val->intval *= 10;
>>
>> I am not convinced this is needed at all. You basically chain two
>> subsystems only to report to user-space via power supply, but it is
>> already reported via IIO. I would understand it if you use the value for
>> something, e.g. control the charger. Here, it's just feeding different
>> user-space interface. Therefore:
>> 1. IO channels are not a hardware property of the fuel gauge,
>> 2. I have doubts this should be even exposed via power supply interface.
>>
>
> I can assure you that this is only the beginning of weird vendor solutions
> I have discovered. Nonetheless, max17040 has no battery temp property,
> this means in case I have a critical battery overheating, userspace
> will tell me nothing
Of course will tell you - via IIO.
> since instead of having direct battery temp property under power supply I have
> separate iio sensor, which may not even be monitored. It is always nice to have
> battery explosions.
Hm, ok, I defer this to Sebastian. What's the policy - who should report
battery temperature if the battery/FG itself does not have any sensor?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-08 10:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 8:44 [PATCH v1 0/4] Add optional properties to MAX17040 Svyatoslav Ryhel
2023-03-08 8:44 ` [PATCH v1 1/4] dt-bindings: power: supply: maxim,max17040: update properties Svyatoslav Ryhel
2023-03-08 9:04 ` Krzysztof Kozlowski
2023-03-08 9:15 ` Svyatoslav Ryhel
2023-03-08 10:44 ` Krzysztof Kozlowski
2023-03-08 10:51 ` Svyatoslav Ryhel
2023-03-08 10:53 ` Krzysztof Kozlowski
2023-03-08 11:06 ` Svyatoslav Ryhel
2023-03-08 11:12 ` Krzysztof Kozlowski
2023-05-15 22:17 ` Sebastian Reichel
2023-03-08 8:44 ` [PATCH v1 2/4] power: max17040: add simple battery cell support Svyatoslav Ryhel
2023-05-15 22:21 ` Sebastian Reichel
2023-03-08 8:44 ` [PATCH v1 3/4] power: max17040: add passing props from supplier Svyatoslav Ryhel
2023-05-15 22:41 ` Sebastian Reichel
2023-03-08 8:44 ` [PATCH v1 4/4] power: max17040: get thermal data from adc if available Svyatoslav Ryhel
2023-03-08 9:08 ` Krzysztof Kozlowski
2023-03-08 9:23 ` Svyatoslav Ryhel
2023-03-08 10:46 ` Krzysztof Kozlowski [this message]
2023-03-09 0:24 ` kernel test robot
2023-03-09 0:24 ` kernel test robot
2023-03-09 0:45 ` kernel test robot
2023-05-15 22:39 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74ba115e-9838-4983-7b93-188a8260dd8a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=clamor95@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=matheus@castello.eng.br \
--cc=me@iskren.info \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®