From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 0796F13FEE
	for <linux-kernel@vger.kernel.org>; Mon, 23 Dec 2024 17:06:06 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1734973568; cv=none; b=CjY6TIJsTlYbzfwuZ5aTCwrjVFAciW69+CHvQtWcqB4i7ho4RWWpGwXVYqX8Rp654Yaodk7lLgjkxN39DGUWtLj2TJxIXRw9qi7sbD1YqmwDl46WNs/ThiM5v+7W5e53jIVO/EUOz7/r8VM2gkeMcSoDLxhfpPXTlQjFe+CbYBs=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1734973568; c=relaxed/simple;
	bh=6H00LukXmEFHQ/gVJJuEscDiYI2iaQ2lXIz1XKY4Kjc=;
	h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:
	 In-Reply-To:Content-Type; b=nydwpgRLdG5RcLnWFfvgbODlGUUo/NY5U5xi6HHM9OZNo3O9HLeJYobrZm0HtK17iRgIeYSnhlMb2LKl1gokmmWwiOp1BiihIkvejwL9xRior8eFzzz2eq49VZxms6CwaWXG6MXKXl1d/iyEOdmnIPOXw8Lsc+X3YOYdqAqhip8=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A06CB1424;
	Mon, 23 Dec 2024 09:06:34 -0800 (PST)
Received: from [10.57.73.219] (unknown [10.57.73.219])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 09C653F694;
	Mon, 23 Dec 2024 09:06:03 -0800 (PST)
Message-ID: <74c43172-b55e-4c50-8a6d-061f616748d7@arm.com>
Date: Mon, 23 Dec 2024 17:06:01 +0000
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH 1/4] drm/panthor: Add 64-bit register accessors
To: Karunika Choo <karunika.choo@arm.com>, dri-devel@lists.freedesktop.org
Cc: nd@arm.com, Boris Brezillon <boris.brezillon@collabora.com>,
 Liviu Dudau <liviu.dudau@arm.com>,
 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
 Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>,
 David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
 linux-kernel@vger.kernel.org
References: <20241219170521.64879-1-karunika.choo@arm.com>
 <20241219170521.64879-2-karunika.choo@arm.com>
From: Steven Price <steven.price@arm.com>
Content-Language: en-GB
In-Reply-To: <20241219170521.64879-2-karunika.choo@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 19/12/2024 17:05, Karunika Choo wrote:
> This patch adds 64-bit register accessors to simplify register access in
> Panthor. It also adds 64-bit variants for read_poll_timeout and replaces
> all 64-bit and poll register accesses with these new functions.
> 
> Signed-off-by: Karunika Choo <karunika.choo@arm.com>

(Minor NIT: This might be easier to review as two patches - one which
adds the new functions and a second which switching the code over to use
them).

[...]

> diff --git a/drivers/gpu/drm/panthor/panthor_regs.h b/drivers/gpu/drm/panthor/panthor_regs.h
> index b7b3b3add166..269c2c68dde2 100644
> --- a/drivers/gpu/drm/panthor/panthor_regs.h
> +++ b/drivers/gpu/drm/panthor/panthor_regs.h
> @@ -10,6 +10,9 @@
>  #ifndef __PANTHOR_REGS_H__
>  #define __PANTHOR_REGS_H__
>  
> +#include <linux/iopoll.h>
> +
> +/* GX10 registers */

NIT: Please don't include unrelated changes like this comment.

Other than those minor issues, this looks like a nice improvement.

Steve