From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753081AbdBMOTN convert rfc822-to-8bit (ORCPT ); Mon, 13 Feb 2017 09:19:13 -0500 Received: from smtp.ctxuk.citrix.com ([185.25.65.24]:29183 "EHLO SMTP.EU.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752146AbdBMOTM (ORCPT ); Mon, 13 Feb 2017 09:19:12 -0500 X-IronPort-AV: E=Sophos;i="5.35,156,1484006400"; d="scan'208";a="40660523" From: Paul Durrant To: "'Boris Ostrovsky'" , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" CC: Juergen Gross Subject: RE: [PATCH v2 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP Thread-Topic: [PATCH v2 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP Thread-Index: AQHSg6lryuDqq2MGNUCsZBKa112ujKFiWksAgAATDNCAAAVWAIAENdXggABEw4CAABM0AA== Date: Mon, 13 Feb 2017 14:19:10 +0000 Message-ID: <74c64ea31c51437eb718a94968809a0a@AMSPEX02CL03.citrite.net> References: <1486736677-10953-1-git-send-email-paul.durrant@citrix.com> <1486736677-10953-3-git-send-email-paul.durrant@citrix.com> <2937e443-e83f-a8c4-674e-33a49d8d4ba1@oracle.com> <797fa92d018947299249bc92fa8511b9@AMSPEX02CL03.citrite.net> <80386563-dbfb-f43b-10d7-942c7ee6e544@oracle.com> In-Reply-To: <80386563-dbfb-f43b-10d7-942c7ee6e544@oracle.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Boris Ostrovsky [mailto:boris.ostrovsky@oracle.com] > Sent: 13 February 2017 14:09 > To: Paul Durrant ; xen-devel@lists.xenproject.org; > linux-kernel@vger.kernel.org > Cc: Juergen Gross > Subject: Re: [PATCH v2 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP > > > >> How about something like (with rather arbitrary values) > >> > >> #define PRIVCMD_DMOP_MAX_NUM_BUFFERS 16 > >> #define PRIVCMD_DMOP_MAX_TOT_BUFFER_SZ 4096 > >> > >> and make them part of the interface (i.e. put them into privcmd.h)? > > > > Given that the values are arbitrary, I think it may be better to make them > module params. They can then at least be tweaked if privcmd becomes a > problem with later dm_ops. > > Making them adjustable is a good thing but we still need default values. > Oh, sure. I think I'll actually go for 16 bufs and a max of 4k per bufs as defaults. Patch v3 (including a fix for the arm build) coming shortly. Cheers, Paul > > -boris