From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752008AbcHHHPP (ORCPT <rfc822;w@1wt.eu>);
	Mon, 8 Aug 2016 03:15:15 -0400
Received: from szxga03-in.huawei.com ([119.145.14.66]:33810 "EHLO
	szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750916AbcHHHPN (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 8 Aug 2016 03:15:13 -0400
Subject: Re: [PATCH V4]mmc: dw_mmc-k3: UHS-SD card for Hisilicon Hikey
To: <linux-mmc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <ulf.hansson@linaro.org>,
        <adrian.hunter@intel.com>, <jh80.chung@samsung.com>,
        <wsa+renesas@sang-engineering.com>, <arnd@arndb.de>,
        <rmk+kernel@arm.linux.org.uk>, <shawn.lin@rock-chips.com>
References: <1470276973-41683-1-git-send-email-kid.jin@hisilicon.com>
CC: <guodong.xu@linaro.org>, <kongfei@hisilicon.com>,
        <suzhuangluan@hisilicon.com>
From: Jinguojun <kid.jin@hisilicon.com>
Message-ID: <74c80b1c-5570-0ee0-4132-ff703d8d5eb4@hisilicon.com>
Date: Mon, 8 Aug 2016 15:10:31 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <1470276973-41683-1-git-send-email-kid.jin@hisilicon.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.142.148.191]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A020202.57A83078.000F,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-05-26 15:14:31,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 9e30e694502be679f97edb28d593d853
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,maintainers

Pls help to review code,this is the newest patch after your advise

Thx
On 2016/8/4 10:16, Jin Guojun wrote:
> mmc: dw_mmc-k3: Hisilicon Hikey have no tuning function in 
> dw_mmc-k3.c,so we must do the tuning function stub when we init UHS card.
> 
> V1:add .prepare_command in dw_mmc.c
> V2:delete .prepare_command, add err = 0 in dw_mci_execute_tuning
> V3:delete err = 0 in dw_mci_execute_tuning,add .execute_tuning in 
> dw_mmc-k3.c
> V4:add "linux-mmc@vger.kernel.org", patch version, Changelog, etc..
> 
> Signed-off-by: Jin Guojun <kid.jin@hisilicon.com>
> ---
>  drivers/mmc/host/dw_mmc-k3.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/mmc/host/dw_mmc-k3.c b/drivers/mmc/host/dw_mmc-k3.c
> index 8e9d886..6247894 100644
> --- a/drivers/mmc/host/dw_mmc-k3.c
> +++ b/drivers/mmc/host/dw_mmc-k3.c
> @@ -131,11 +131,17 @@ static void dw_mci_hi6220_set_ios(struct dw_mci *host, struct mmc_ios *ios)
>  	host->bus_hz = clk_get_rate(host->biu_clk);
>  }
>  
> +static int dw_mci_hi6220_execute_tuning(struct dw_mci_slot *slot, u32 opcode)
> +{
> +	return 0;
> +}
> +
>  static const struct dw_mci_drv_data hi6220_data = {
>  	.caps			= dw_mci_hi6220_caps,
>  	.switch_voltage		= dw_mci_hi6220_switch_voltage,
>  	.set_ios		= dw_mci_hi6220_set_ios,
>  	.parse_dt		= dw_mci_hi6220_parse_dt,
> +	.execute_tuning		= dw_mci_hi6220_execute_tuning,
>  };
>  
>  static const struct of_device_id dw_mci_k3_match[] = {
>