From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD974C433B4 for ; Thu, 1 Apr 2021 02:42:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FE8061059 for ; Thu, 1 Apr 2021 02:42:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233048AbhDACln (ORCPT ); Wed, 31 Mar 2021 22:41:43 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:15421 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229497AbhDAClN (ORCPT ); Wed, 31 Mar 2021 22:41:13 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4F9nSw3l7pzjX2b; Thu, 1 Apr 2021 10:39:28 +0800 (CST) Received: from [10.174.178.174] (10.174.178.174) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.498.0; Thu, 1 Apr 2021 10:41:07 +0800 Subject: Re: [PATCH -next] staging: greybus: camera: Switch to memdup_user_nul() To: Dan Carpenter CC: , , , , References: <20210331095201.2173793-1-yangyingliang@huawei.com> <20210331102414.GL2065@kadam> From: Yang Yingliang Message-ID: <74cc6ea7-7b03-dea1-ba02-0ad41df29ced@huawei.com> Date: Thu, 1 Apr 2021 10:41:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20210331102414.GL2065@kadam> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.174.178.174] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2021/3/31 18:24, Dan Carpenter wrote: > On Wed, Mar 31, 2021 at 05:52:01PM +0800, Yang Yingliang wrote: >> Use memdup_user_nul() helper instead of open-coding to >> simplify the code. >> >> Reported-by: Hulk Robot >> Signed-off-by: Yang Yingliang >> --- >> drivers/staging/greybus/camera.c | 10 ++-------- >> 1 file changed, 2 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c >> index b570e13394ac..0f005facffbc 100644 >> --- a/drivers/staging/greybus/camera.c >> +++ b/drivers/staging/greybus/camera.c >> @@ -1120,16 +1120,10 @@ static ssize_t gb_camera_debugfs_write(struct file *file, >> if (len > 1024) >> return -EINVAL; >> >> - kbuf = kmalloc(len + 1, GFP_KERNEL); >> - if (!kbuf) >> + kbuf = memdup_user_nul(buf, len); >> + if (IS_ERR(kbuf)) >> return -ENOMEM; > return PTR_ERR(kbuf); > >> >> - if (copy_from_user(kbuf, buf, len)) { >> - ret = -EFAULT; >> - goto done; >> - } >> - >> - kbuf[len] = '\0'; >> > ^^^^^^^^ > Please delete this blank line so there aren't two blank lines in a row. I will change it and send a v2. Thanks, Yang > >> ret = op->execute(gcam, kbuf, len); > regards, > dan carpenter > > .