From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0577EC432BE for ; Wed, 4 Aug 2021 12:25:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DDB1960F22 for ; Wed, 4 Aug 2021 12:25:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238163AbhHDM0E (ORCPT ); Wed, 4 Aug 2021 08:26:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:21828 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238068AbhHDMZU (ORCPT ); Wed, 4 Aug 2021 08:25:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628079905; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sI16fQel/Ue3hvumrMVm+G2pFHp1eoZdAd31v+J9YrE=; b=KNE771nArIfkKdRQU9cgpSNKm8PHeghcBYjbrhxOd/xteaeU2mHsV3I99XUUTP7D7NkQGJ FB3MCv7ZBbXt+pZw7+NOauIDkQ/D2sKZZ1KYHdzZjOx1J65grrBwCFls9gLOsWPvAlWLlU 9Ocn9hABvB9EXW9ELBTpbTpMhSJ1Y4I= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-370-If8-lZydOIijILVNd8rr0Q-1; Wed, 04 Aug 2021 08:25:04 -0400 X-MC-Unique: If8-lZydOIijILVNd8rr0Q-1 Received: by mail-ed1-f71.google.com with SMTP id cm18-20020a0564020c92b02903bc7f21d540so1359891edb.13 for ; Wed, 04 Aug 2021 05:25:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sI16fQel/Ue3hvumrMVm+G2pFHp1eoZdAd31v+J9YrE=; b=aTWg1f9SYX9gzdZPD4doiDBoeCpEeD+L8xTlvCRuZhT0wftquERxWxD2g3lXEzNylB JPFY6PHSyBNLb5tRTgjZMqkrho3FIJYfU383NlHKfjx4K1qshjnQ0HHlUUKZwkqgzKEP CHp6Qg1w78uCMdg26lK1BEEvq54vJL03u4FZwBJszgN8JW/Vi0ZWG7M8dwdBeniETHGY MqZI9dPU3flI6fsG3lsGMO7nKrtB3bWM2yMC1qe7DXbxyGqGaucP/qTmI53u+CstxRPh Z0hWzsHJ7n6yG7RRV8ZGOaJpMx5q43j2pbvuZ7QtDxoRP3yziwnPVliPcMBRBnBWiC0q 5OOw== X-Gm-Message-State: AOAM531ZkxiDcpVWjOLPlC6nO3t2GeMcT+sBv7/P1UIuQl0x62Ih1S6G kljfnCDkIyFKwxnmYlOUwlFQCLlQ0jYmi2+DopBmqyV7TDT/PncYUD0VwWOhhuct0hlCx/EP1kG W7sxqrIjYKpte9sT23NC8HUHW X-Received: by 2002:aa7:dd84:: with SMTP id g4mr31573765edv.134.1628079903499; Wed, 04 Aug 2021 05:25:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwkaiVi1nNq0RDnQQTeashPNGbvIKvldHEWSd3OzLiBffrdBtEgeWSxP9aWUjrB3V8zxmYqGw== X-Received: by 2002:aa7:dd84:: with SMTP id g4mr31573752edv.134.1628079903384; Wed, 04 Aug 2021 05:25:03 -0700 (PDT) Received: from ?IPv6:2001:b07:add:ec09:c399:bc87:7b6c:fb2a? ([2001:b07:add:ec09:c399:bc87:7b6c:fb2a]) by smtp.gmail.com with ESMTPSA id c4sm913819edt.37.2021.08.04.05.25.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Aug 2021 05:25:02 -0700 (PDT) Subject: Re: [PATCH] KVM: selftests: fix hyperv_clock test To: Maxim Levitsky , kvm@vger.kernel.org Cc: Sean Christopherson , Shuah Khan , Vitaly Kuznetsov , linux-kernel@vger.kernel.org, "open list:KERNEL SELFTEST FRAMEWORK" References: <20210804112057.409498-1-mlevitsk@redhat.com> From: Paolo Bonzini Message-ID: <74cec7b5-ae92-2f34-9aa5-30306509f933@redhat.com> Date: Wed, 4 Aug 2021 14:24:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210804112057.409498-1-mlevitsk@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/08/21 13:20, Maxim Levitsky wrote: > The test was mistakenly using addr_gpa2hva on a gva > and that happened to work accidentally. > > commit 106a2e766eae ("KVM: selftests: > Lower the min virtual address for misc page allocations") > revealed this bug. > > Fixes: 106a2e766eae ("KVM: selftests: Lower the min virtual address for misc page allocations") The right "Fixes" is 2c7f76b4c42b ("selftests: kvm: Add basic Hyper-V clocksources tests", 2021-03-18). Paolo > Signed-off-by: Maxim Levitsky > --- > tools/testing/selftests/kvm/x86_64/hyperv_clock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/kvm/x86_64/hyperv_clock.c b/tools/testing/selftests/kvm/x86_64/hyperv_clock.c > index bab10ae787b6..e0b2bb1339b1 100644 > --- a/tools/testing/selftests/kvm/x86_64/hyperv_clock.c > +++ b/tools/testing/selftests/kvm/x86_64/hyperv_clock.c > @@ -215,7 +215,7 @@ int main(void) > vcpu_set_hv_cpuid(vm, VCPU_ID); > > tsc_page_gva = vm_vaddr_alloc_page(vm); > - memset(addr_gpa2hva(vm, tsc_page_gva), 0x0, getpagesize()); > + memset(addr_gva2hva(vm, tsc_page_gva), 0x0, getpagesize()); > TEST_ASSERT((addr_gva2gpa(vm, tsc_page_gva) & (getpagesize() - 1)) == 0, > "TSC page has to be page aligned\n"); > vcpu_args_set(vm, VCPU_ID, 2, tsc_page_gva, addr_gva2gpa(vm, tsc_page_gva)); >