From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com [209.85.161.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B0E2175A66 for ; Thu, 25 Jun 2026 15:37:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782401878; cv=none; b=t0wyKbNfEdg0gAMfpc2MSoBFENy/fcMkfedHiGqMzgyGi2BDopb7j73cvfHkOZGDrpH9EPcDIqJnwuJTVGC8nTiqNx20zplRfEdDdS3EJWQC+GmrIsCKuxroatvhqX06DjV4mSjcFp6euKo7X7mUPd0wT+F2SXLEFPQbLrKeCjk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782401878; c=relaxed/simple; bh=XCiyN2t+pubmU+TId5wjtZxQ4PDKqqjMsgC4L0ovpx8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=M3ChSzmORWkFa3VdpLVxL5HPmt+LiGCmbPkAacGWMZCE2HJtcrwg/iJsaI/dXZRXfxyxxfUKIEMlz8UOXUKIoUG8j47FsJS/+uJKQwl0ec5HZWo27x9pF0LedNMFrLLsBQH0N3y4Xr/9eUvgVXN083OlhMLespQlOjJ4KhCnFCk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=TaertQYY; arc=none smtp.client-ip=209.85.161.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="TaertQYY" Received: by mail-oo1-f41.google.com with SMTP id 006d021491bc7-6a0a38a013eso993862eaf.0 for ; Thu, 25 Jun 2026 08:37:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1782401876; x=1783006676; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=APys4KeLv4YSCQ/l/Owb8+z+6axIvcyEL3NASaVFnbA=; b=TaertQYY03CKsry73K9QxsG8Ca9RY4oeO8JFo7lMl3XUzwtkJ0a5appoHwbryNWmz0 +ongHyI1A7F4FDWT3npYzQgWdTwpB0nq9WabC6wJVxdQ1WEAZFrwLbTPUUIkU6cyj2/p gkqeR7QDN3e1vVVe+nIRqgUDzthutcmrRhU10= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782401876; x=1783006676; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=APys4KeLv4YSCQ/l/Owb8+z+6axIvcyEL3NASaVFnbA=; b=dyeQo5v13lI97DvfxvcepirdgZwLt7YLFTniqrf9DwfzwOHE3pvZ0LTFq5GAOOLktk OdDtUm6C7ZC15sW++5eRbbpX0zdQcY/HhnxD/BeuK6ZRjHz/2SMJ3xeugtD/XaaGcPss uGLAK2PRYVoC4HiWxJUr7ONwXnGIOJKEAr5tbZUeYcv8X1XZ9YFV3ww6iiVCKwBf31A5 C4aDO8e6W80lG5+BNNKrewl45NyyjZG0GxG8JCsH6DYBFhe6W9sPocNxv4dFCqFAVDBY tiZhGsLocOCKzlM44nV1QHcRAdyA8DKjNpZQgzt+KWZuOzXOGa7zgFk96M9VMYSeRUG9 vziA== X-Forwarded-Encrypted: i=1; AFNElJ8BIxxlmrUdTLUuAUwllYnyvUDOdfoo3S09AK/t7DuNLre0+WZv8lI+qry/1IfO6zuGGNvsTaQZGpifzFo=@vger.kernel.org X-Gm-Message-State: AOJu0YyeiGdCAQJk/6LmebaRzDTOKLuB5F5WDpFypzYaYp/WUJL1CGFR p6hjXhf2tJCgpFPcb0rH1mMujOwRChExKkF2XwF1Hsphg7PeF0SyvqqvXKGcDKxsnsEJFAhVErS mnywg9M4= X-Gm-Gg: AfdE7cmDdkX5w+MeDUwfdjPcEurhk4Ms8g/DTkidZNwTRLoUTkWg4FFhB8DcN5kRkvw A+wmCtLfKA6Yl/CVeyDWf8BDgPvGjaJR2KSHV+M9tmzJzgHLlJNN7szQSqF0JAj1NLTV6gfigbq 0hZwkPvlGJXvblvVwmGuL3RTnbcTGFy1fkf70tPhWiKAK6Cuqf7AgdfvIzlSqehNlmZt1oHTT7k aYP65+DNO4Ry/dGG0gvxdbfqxafzRrrt+chXax/nZC3XaAWtTVQ9UDWSTHSQ7w2Vkc/QKb65Y76 tg1NdlBBveVqnpxI7AjNpBvF/bdjuexeEsARNyw6LAthjR7nnps6w9HSvdS5VuKAdwATJVuNVF+ ZMExGyu3x2NHoEPa6nqcsCIrfEv894vkPYwXvrStoEHbTWo9C+xAXGdyj102ZgS7cpXdwt7bYPa vWQRCefnEh4CTmi3C9HHxb X-Received: by 2002:a05:6820:2015:b0:6a1:1015:30ec with SMTP id 006d021491bc7-6a134243f7emr1795364eaf.7.1782401876014; Thu, 25 Jun 2026 08:37:56 -0700 (PDT) Received: from [192.168.1.14] ([38.15.57.99]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6a0ea0c378csm10262630eaf.10.2026.06.25.08.37.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jun 2026 08:37:55 -0700 (PDT) Message-ID: <74d0c7dd-50cd-44b9-9723-101f3bcf4760@linuxfoundation.org> Date: Thu, 25 Jun 2026 09:37:54 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] usbip: tools: support SuperSpeed Plus devices To: Greg KH , raoxu Cc: valentina.manea.m@gmail.com, shuah@kernel.org, i@zenithal.me, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <1B3C4D10DA532DC9+20260622100802.377751-1-raoxu@uniontech.com> <2026062527-unmoral-drop-down-9ade@gregkh> Content-Language: en-US From: Shuah Khan In-Reply-To: <2026062527-unmoral-drop-down-9ade@gregkh> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/25/26 09:09, Greg KH wrote: > On Mon, Jun 22, 2026 at 06:08:02PM +0800, raoxu wrote: >> From: Xu Rao >> >> USB/IP reads a remote device's speed from the server-side sysfs >> "speed" attribute. read_attr_speed() converts the string to >> enum usb_device_speed before the value is sent to the client. >> >> The conversion table only recognizes 5000 Mbps. Devices reporting >> 10000 or 20000 Mbps are therefore sent as USB_SPEED_UNKNOWN. The >> client then selects a USB 2.0 VHCI port, and the kernel rejects the >> attach request because USB_SPEED_UNKNOWN is not a supported speed. >> >> Map both SuperSpeed Plus sysfs values to USB_SPEED_SUPER_PLUS and >> select the SuperSpeed VHCI hub for that speed. >> >> The issue was reproduced with the following server hardware: >> >> xHCI controller: Intel 8086:a0ed, revision 20 >> Subsystem: Lenovo 17aa:382a >> USB device: Silicon Motion 090c:2320 mass storage >> sysfs speed: 10000 Mbps >> >> Before the change: >> >> $ usbip attach -r 10.20.12.170 -b 2-2 >> usbip: error: import device >> >> After the change, the device attaches and uses usb-storage: >> >> $ usbip port >> Port 08: at Super Speed(5000Mbps) >> 8-1 -> usbip://10.20.12.170:3240/2-2 >> >> VHCI currently exposes the imported device as SuperSpeed, so the >> client reports 5000 Mbps instead of 10000 Mbps. This is a separate >> speed-reporting limitation and does not prevent attachment or I/O. >> >> Signed-off-by: Xu Rao >> --- >> tools/usb/usbip/libsrc/usbip_common.c | 2 ++ >> tools/usb/usbip/libsrc/vhci_driver.c | 1 + >> 2 files changed, 3 insertions(+) > > Isn't this covered by this change: > https://lore.kernel.org/r/00C828F338E43447+20260617020613.199086-1-chenyichong@uniontech.com > This one was sent first. They look identical. I will go review that now. thanks, -- Shuah