Re: [RFC PATCH 0/3] GPIO switch framework

[pHilipp Zabel <philipp.zabel@gmail.com>]

Hi,

On Fri, Mar 20, 2009 at 2:50 PM, Jani Nikula
<ext-jani.1.nikula@nokia.com> wrote:
>
> Hi -
>
> This RFC patchset is a pretty straightforward adaptation of OMAP GPIO
> switch framework for mainline integration.
>
> The GPIO switch framework allows reporting and changing GPIO switches
> via sysfs, with debouncing and sysfs/in-kernel notifications for input
> switches.

Doesn't this partially duplicate what the input layer is for?
There is also a gpio-keys driver in input/keyboard already that can
report switch events (EV_SW) to the input layer, but it doesn't have
the in-kernel notification.

> The switches are added as /sys/class/gpio/switch-<switch name> under
> the gpiolib sysfs structure.
>
> BR,
> Jani.
>
>
> Jani Nikula (3):
>      GPIOLIB: Add new gpio_device_create function
>      GPIO-SWITCH: Adaptation of GPIO switch framework for mainline
>      GPIO-SWITCH: Kconfig and Makefile
>
>  drivers/gpio/Kconfig        |   10 +
>  drivers/gpio/Makefile       |    2 +
>  drivers/gpio/gpio-switch.c  |  534 +++++++++++++++++++++++++++++++++++++++++++
>  drivers/gpio/gpiolib.c      |   52 +++++
>  include/asm-generic/gpio.h  |   12 +
>  include/linux/gpio-switch.h |   74 ++++++
>  6 files changed, 684 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/gpio/gpio-switch.c
>  create mode 100644 include/linux/gpio-switch.h
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

regards
Philipp