From: Guenter Roeck <linux@roeck-us.net>
To: "Angus Ainslie (Purism)" <angus@akkea.ca>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/1] usb: typec: tcpci: read the VBUS_VOLTAGE register
Date: Tue, 7 May 2019 18:47:43 -0700 [thread overview]
Message-ID: <74d20a42-b6cf-48d3-7777-a44e500b0eed@roeck-us.net> (raw)
In-Reply-To: <20190508004027.16558-1-angus@akkea.ca>
On 5/7/19 5:40 PM, Angus Ainslie (Purism) wrote:
> I don't have a setup that I can test this code right now.
>
> I did test the tcpci_get_vbus_voltage and on my setup it is always 0.
>
Odd. PTN5110 is supposed to support it, though the datasheet is a bit vague about it.
It may be disabled. Did you check the status of POWER_CONTROL.VBUS_VOLTAGEMonitor ?
> I don't currently have setup that I can adjust the vbus voltage to
> trigger the fault.
>
> Angus Ainslie (Purism) (1):
> usb: typec: tcpci: add functions to read the VBUS voltage
>
> drivers/usb/typec/tcpm/tcpci.c | 35 ++++++++++++++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
>
In general, an introductory patch is only useful if there is more than one patch.
Thanks,
Guenter
prev parent reply other threads:[~2019-05-08 1:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 0:40 Angus Ainslie (Purism)
2019-05-08 0:40 ` [PATCH 1/1] usb: typec: tcpci: add functions to read the VBUS voltage Angus Ainslie (Purism)
2019-05-08 1:59 ` Guenter Roeck
2019-05-08 1:47 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74d20a42-b6cf-48d3-7777-a44e500b0eed@roeck-us.net \
--to=linux@roeck-us.net \
--cc=angus@akkea.ca \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®