From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752237AbdLALmP (ORCPT ); Fri, 1 Dec 2017 06:42:15 -0500 Received: from mail-pl0-f67.google.com ([209.85.160.67]:33792 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752076AbdLALmN (ORCPT ); Fri, 1 Dec 2017 06:42:13 -0500 X-Google-Smtp-Source: AGs4zMYkOZEtyqaFJcEzPfeloY1nMBEXQNdwQqv4Rx7A+A1jz7hHKoBQuO3OroSfdeKBBqyY9FmMUg== Subject: Re: [PATCH 3/3] arm: dts: mt7623: fix card detection issue on bananapi-r2 To: sean.wang@mediatek.com, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <88269ed11bdf881087f7b0de331a60d8acfdc977.1511949769.git.sean.wang@mediatek.com> From: Matthias Brugger Message-ID: <74d7da4b-bb5a-f3f9-6c9e-9cf2fca69c5d@gmail.com> Date: Fri, 1 Dec 2017 12:42:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <88269ed11bdf881087f7b0de331a60d8acfdc977.1511949769.git.sean.wang@mediatek.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/29/2017 11:10 AM, sean.wang@mediatek.com wrote: > From: Sean Wang > > Fix that bananapi-r2 booting from SD-card would fail since incorrect > polarity is applied to the previous setup with GPIO_ACTIVE_HIGH. > > Cc: stable@vger.kernel.org # v4.14+ > Fixes: 0eed8d097612 ("arm: dts: mt7623: Add SD-card and EMMC to bananapi-r2") > Signed-off-by: Sean Wang > --- Tested-by: Matthias Brugger > arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts > index 688a863..7bf5aa2 100644 > --- a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts > +++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts > @@ -204,7 +204,7 @@ > bus-width = <4>; > max-frequency = <50000000>; > cap-sd-highspeed; > - cd-gpios = <&pio 261 0>; > + cd-gpios = <&pio 261 GPIO_ACTIVE_LOW>; > vmmc-supply = <&mt6323_vmch_reg>; > vqmmc-supply = <&mt6323_vio18_reg>; > }; >