mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Brendan Jackman <jackmanb@google.com>, Shuah Khan <shuah@kernel.org>
Cc: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Shuah Khan" <skhan@linuxfoundation.org>
Subject: Re: [PATCH RESEND v3] selftests/run_kselftest.sh: exit with error if tests fail
Date: Wed, 19 Nov 2025 15:01:27 -0700	[thread overview]
Message-ID: <74d8f1bc-e2e0-4c14-b0b2-b1d9380a5b95@linuxfoundation.org> (raw)
In-Reply-To: <20251111-b4-ksft-error-on-fail-v3-1-0951a51135f6@google.com>

On 11/11/25 10:36, Brendan Jackman wrote:
> Parsing KTAP is quite an inconvenience, but most of the time the thing
> you really want to know is "did anything fail"?
> 
> Let's give the user the his information without them needing
> to parse anything.
> 
> Because of the use of subshells and namespaces, this needs to be
> communicated via a file. Just write arbitrary data into the file and
> treat non-empty content as a signal that something failed.
> 
> In case any user depends on the current behaviour, such as running this
> from a script with `set -e` and parsing the result for failures
> afterwards, add a flag they can set to get the old behaviour, namely
> --no-error-on-fail.
> 
> Signed-off-by: Brendan Jackman <jackmanb@google.com>

Applied to linux-kselftest next for Linux 6.19-rc1

thanks,
-- Shuah

      reply	other threads:[~2025-11-19 22:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-11 17:36 Brendan Jackman
2025-11-19 22:01 ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74d8f1bc-e2e0-4c14-b0b2-b1d9380a5b95@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=jackmanb@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=thomas.weissschuh@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®