From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.216.52 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792973847; b=suVSfee/gtVJYKYmnc5OzoHi9oKER/SnUrvNJABwSRMYUdqmJb5g8lb14XIR9dMLYfMj L1b/X4Tq1pTggoPYoJGyDmqwVpg/Lj6XjfECv2ZEhgLcUkjqI2QQEJb6QH779sAXeCi7I gmdV20mu9CIHOPn532+VKs/HcEDVu6Yb9mPcz+a6Xn1z7gpp5xEwyn7HdGyVkw0OxPboX dZ9e6cV23G0QYWcHzVmUKUkMO/i62TBk7bhpbBwwpnutPMnPjw0K4PISx8XiKCEb9e+p5 fPHupz/Mlse2G77tk+z5D8lKSomLi1pjelZn2xhZA7uWG4lkmRMxS92V4gbE9x07ofQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792973847; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Sender:Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=LPTdpqzsQ7lCEGZ4cwq1P1wG3qp/qnOV8StpunplMto=; b=OevvjEg83aNGIPw2iG466hquXJyBqJ4yA+jM2GyfWi806IuZp/HscGzIG7Qn6e+449T0 hv5ZLTtfYY2zwPqNx2jhkXbMfXOmXSxhq77OIa/3yhFXnHMP2jk4nAr2hPlzV0Afg/JX4 NISSOui+13BAB+ghfNulI3HwpPgG/PEMVNmjMe55gxP1WYge8SjBzqY1g0Jcq7L5Flcm1 ypyqP35LjOVnpSzVYssoVbbHcnPxSifYyyuVQ11bb5sSYEiQbeb7H7t8fhDv90J68daDL dGEJ1TCEKDyMtXmBQ/75le9tcRL3U8jygMhNFj3R0kWtZ+Wdz0hzumP/bbdOIHwneFQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=nZPqyslh; arc=none smtp.remote-ip=209.85.216.52 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95E4B606A31A for ; Mon, 26 Oct 2026 00:17:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 95E4B606A31A Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=nZPqyslh Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-3ada4c06b7bso1148777a91.2 for ; Sun, 25 Oct 2026 17:17:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792973846; x=1793578646; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:from:to:cc :subject:date:message-id:reply-to:content-type; bh=LPTdpqzsQ7lCEGZ4cwq1P1wG3qp/qnOV8StpunplMto=; b=nZPqyslhbzKokYUQ5Gd1QVVdXwOKB8xjLeyBBFK0bS09nHL/PokKpSPRjVYB/vseCM 793pUVViXjlFQUd/kA0jvXOrUswTqcutxj/4yTjqvOvdlQk+OatQXEkA8mcVrbsXN/N9 b63dMgzZU0XlGlNif2NqzBSEB+TSOaqQCULrmaB/Zye2vVHThhsa+8qhQFGd8H31hDiz RYoe6io1uU0XKCZ8Rt2pjFEogOXtpcMiTRbJxmlCwYUZgojyriChLay4GJku9/GQi+an GaBotTBVrT9WwbwdB5ytAeuH/djdrnSJf14OnJTF9LUxSDQynCek6oL5JnbloqDkeU8P gujw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792973846; x=1793578646; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=LPTdpqzsQ7lCEGZ4cwq1P1wG3qp/qnOV8StpunplMto=; b=AHTLZbVpzRZbBZep/RAo0/btTdBnboLDPUSa35/J6R/RIfBTk+wSGR9q8nwZYbSEro hotxiZu36MN12XUj/REzWZqZENrDDUQeDfh4BSSaaAS198lW6tXsNlC5pg9C8eq5DQHX AZCAT6FTuwY3GeiaX6D+hStOsqeJ5+QhlJGIfkIw9+vU5xSyddqtZqyhX2zrUqHp8580 3uvJikQeieI2mtBZxN/cCeo1XG5mVvEZZwpq8U7htI2H14DYuUJrQjiIIqLgmZNm6qch CRhLEMqG9m6Rq3+tibpogYtxVtNL5TdQV8ItOd2DLKsVdMjUOxsk470SxsXOF/9LZcqs gupQ== X-Forwarded-Encrypted: i=1; AKwUvBzDbM3NqkWrQOLkSF0HXg5d0nBWwO71qXUFzXYEg6F4zXCO5PPGAeGP0K+28XX0viTlg1o1PsssFF4JUQ4=@vger.kernel.org X-Gm-Message-State: AFq9FYKizdjaHKHmMtcZr5lys5XytdVqXMFtd/imfqhV0a77Xfts5EG5 KzyQM35ziYxUYH3IiRhtaTUiXynIBEq5MQm2kjUBx3IvXAiLqUpQRZUI7aETsw== X-Gm-Gg: AYBFou08K4NrRl+jyCoeuovSadX7hKV8QxHga4wainjrGtgHr7RHKvqUa/PVrr9lwmE Lzt/e0W+w4r0gYfkg00jzH0BjKSFmCspIPUgwAzgrXbLTHK3C8PodqdN8GS8thFiLiIBe3h2RXd u5pAGbyAiwWBjqL1xetQvg588DEIVif5OGEezGb3nekZ+GEH7KoQTnyOts678glp1CTv4spDmCI p6U3ldhNkwR0YfyT3NMRXZhsaJPzqAAuIpUTlPvRLvI4ATtgLa7DJ/X34lWFrr9LetwROuKQnYM wdLRBW6YICenriXS1ASI1m8aKxqJyI/Oicziwe13EqIHkgla6KkgRi2DnBEQRSq4c8+f34nzOPu XNiyHHm9fReotlW7MnsiHw9moADqpyb/UTa4TmI4JhKhUvpoR/AzyVkTElCPwNAN5i1ia/tNt6k GJaUdpvxORlh248sgiwYakKRSRTG8FNJh9l4x5wqqgkn36Bg8ngspW/hxJXEd+tHmRHCeXd7Bv0 OMNFU/vZgtLRaQnQq14DRxS+2Ae33i8e5Fl/Qb3HnYBFni5caJMPZXpa5yRY9r74mrGFA== X-Received: by 2002:a17:90b:35c2:b0:3ac:a521:960 with SMTP id 98e67ed59e1d1-3adea07d5c8mr4463949a91.1.1792973845866; Sun, 25 Oct 2026 17:17:25 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3adebe8f0b2sm5963064a91.8.2026.10.25.17.17.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Oct 2026 17:17:25 -0700 (PDT) Sender: Guenter Roeck Date: Sun, 25 Oct 2026 17:17:24 -0700 From: Guenter Roeck To: pocj8ur4in Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hwmon: (lm87) Propagate analog output write errors Message-ID: <74e00272-306d-4d83-b6f6-10059ad3a91f@roeck-us.net> References: <20261025150800.49041-1-pocj8ur4in@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261025150800.49041-1-pocj8ur4in@gmail.com> On Mon, Oct 26, 2026 at 12:08:00AM +0900, pocj8ur4in wrote: > From: "Baek Kyu, Kim" > > The aout_output store path updates its cached value before writing the > register and ignores the SMBus result. A rejected write therefore returns > a successful byte count and reports the requested value until the cache > expires. With a cached 980 mV, a rejected write of 1960 mV returned 5 and > read back as 1960 mV although the register still held 980 mV. > > Check the write result and update the cache only after success. Return the > bus error to the sysfs caller. > > Signed-off-by: Baek Kyu, Kim NACK, for a simple reason: This driver has 23 instances of unchecked I2C writes. This patch fixes _one_ of them. I am not going to waste my time reviewing 23 separate patches, each of them fixing one instance of an unchecked write, plus another set of patches fixing all the unchecked read operations. Guenter