From: Florian Fainelli <f.fainelli@gmail.com>
To: "Sheetal Tigadoli" <sheetal.tigadoli@broadcom.com>,
"Rafał Miłecki" <zajec5@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Michal Simek" <michal.simek@xilinx.com>,
"Rajan Vaja" <rajan.vaja@xilinx.com>,
"Scott Branden" <scott.branden@broadcom.com>,
"Ray Jui" <ray.jui@broadcom.com>,
"Vikram Prakash" <vikram.prakash@broadcom.com>,
"Jens Wiklander" <jens.wiklander@linaro.org>,
"Michael Chan" <michael.chan@broadcom.com>,
"David S. Miller" <davem@davemloft.net>,
"Vikas Gupta" <vikas.gupta@broadcom.com>,
"Vasundhara Volam" <vasundhara-v.volam@broadcom.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
tee-dev@lists.linaro.org, bcm-kernel-feedback-list@broadcom.com,
netdev@vger.kernel.org
Subject: Re: [PATCH V3 0/3] Add OP-TEE based bnxt f/w manager
Date: Thu, 24 Oct 2019 17:06:42 -0700 [thread overview]
Message-ID: <74e019d5-25cf-b2e8-6f54-9afbefa28568@gmail.com> (raw)
In-Reply-To: <183f68bc-8145-ef98-07ca-8d3f85d66a17@gmail.com>
On 10/24/19 11:39 AM, Florian Fainelli wrote:
> On 10/23/19 10:32 PM, Sheetal Tigadoli wrote:
>> This patch series adds support for TEE based BNXT firmware
>> management module and the driver changes to invoke OP-TEE
>> APIs to fastboot firmware and to collect crash dump.
>
> Sorry for chiming on this so late, the more I look into this and the
> more it seems like you have built a custom TEE firmware loading solution
> rather than thinking about extending the firmware API to load a firmware
> opaque handle from somewhere other than the filesystem.
>
> The TEE integration appears okay to me in that you leverage the TEE bus
> to advertise your driver. What seems to violating layers is that you
> have bnxt directly tap into your TEE driver's services and that looks
> not ideal to say the least. That approach does not scale well over
> multiple drivers (bnxt or otherwise), but also does not really scale
> over trusted components providers. TEE is one of them, but conceptually
> the same thing could exist with ACPI/UEFI or any platform that has
> services that offer some sort of secure/non-secured world differentiation.
>
> The way I would imagine you to integrate this is to basically register a
> TEE firmware provider through the firmware API, continue using the
> firmware API from within bnxt, possibly with using a specific file
> handle/flag that designates whether you want to favor loading from
> disk/file system or TEE. It should not matter to bnxt how the firmware
> is obtained basically.
And I should have probably ended this paragraph with saying that the
suggestion does not need to happen right now but would be nice to be
done as a cleanup exercise (of course, by saying that, I am also opening
the door for this to not happen at all..).
--
Florian
next prev parent reply other threads:[~2019-10-25 0:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 5:32 Sheetal Tigadoli
2019-10-24 5:32 ` [PATCH V3 1/3] firmware: broadcom: add OP-TEE based BNXT " Sheetal Tigadoli
2019-10-24 18:54 ` Jakub Kicinski
2019-10-27 5:12 ` kbuild test robot
2019-10-30 10:44 ` [Tee-dev] " Sumit Garg
2019-10-24 5:32 ` [PATCH V3 2/3] bnxt_en: Add support to invoke OP-TEE API to reset firmware Sheetal Tigadoli
2019-10-24 5:32 ` [PATCH V3 3/3] bnxt_en: Add support to collect crash dump via ethtool Sheetal Tigadoli
2019-10-24 18:55 ` Jakub Kicinski
2019-10-24 18:39 ` [PATCH V3 0/3] Add OP-TEE based bnxt f/w manager Florian Fainelli
2019-10-25 0:06 ` Florian Fainelli [this message]
2019-10-28 18:49 ` David Miller
2019-10-28 19:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74e019d5-25cf-b2e8-6f54-9afbefa28568@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=jens.wiklander@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=rajan.vaja@xilinx.com \
--cc=ray.jui@broadcom.com \
--cc=scott.branden@broadcom.com \
--cc=sheetal.tigadoli@broadcom.com \
--cc=tee-dev@lists.linaro.org \
--cc=vasundhara-v.volam@broadcom.com \
--cc=vikas.gupta@broadcom.com \
--cc=vikram.prakash@broadcom.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome