From: "Liu, Jingqi" <jingqi.liu@intel.com>
To: Baolu Lu <baolu.lu@linux.intel.com>, <iommu@lists.linux.dev>,
Tian Kevin <kevin.tian@intel.com>, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATH v5 3/3] iommu/vt-d: debugfs: Support dumping a specified page table
Date: Tue, 17 Oct 2023 11:02:08 +0800 [thread overview]
Message-ID: <74e3348c-e02a-7b78-beef-9bcf16b8c7f7@intel.com> (raw)
In-Reply-To: <fd56b69d-d9ea-411c-9eaa-454b3d64f51e@linux.intel.com>
On 10/16/2023 11:04 AM, Baolu Lu wrote:
> On 10/13/23 9:58 PM, Jingqi Liu wrote:
>>
......
>> + if (scalable) { /* scalable mode */
>> + struct pasid_dir_entry *dir_tbl, *dir_entry;
>> + struct pasid_entry *pasid_tbl, *pasid_tbl_entry;
>> + u16 pasid_dir_size, dir_idx, tbl_idx, pgtt;
>> + u64 pasid_dir_ptr;
>
> 0day robot complained:
>
> drivers/iommu/intel/debugfs.c: In function
> 'domain_translation_struct_show':
> >> drivers/iommu/intel/debugfs.c:401:29: warning: variable
> 'pasid_dir_size' set but not used [-Wunused-but-set-variable]
> 401 | u16 pasid_dir_size, dir_idx,
> tbl_idx, pgtt;
> | ^~~~~~~~~~~~~~
>
> I have removed pasid_dir_size and queue the whole series for v6.7.
>
Thanks Baolu.
Indeed. It's an unused variable.
BR,
Jingqi
> Thank you!
>
> Best regards,
> baolu
prev parent reply other threads:[~2023-10-17 3:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 13:58 [PATH v5 0/3] iommu/vt-d: debugfs: Enhancements to IOMMU debugfs Jingqi Liu
2023-10-13 13:58 ` [PATH v5 1/3] iommu/vt-d: debugfs: Dump entry pointing to huge page Jingqi Liu
2023-10-13 13:58 ` [PATH v5 2/3] iommu/vt-d: debugfs: Create/remove debugfs file per {device, pasid} Jingqi Liu
2024-11-12 21:22 ` Kees Bakker
2024-11-13 2:13 ` Baolu Lu
2024-11-13 20:35 ` Kees Bakker
2024-11-14 1:29 ` Baolu Lu
2023-10-13 13:58 ` [PATH v5 3/3] iommu/vt-d: debugfs: Support dumping a specified page table Jingqi Liu
2023-10-16 3:04 ` Baolu Lu
2023-10-17 3:02 ` Liu, Jingqi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74e3348c-e02a-7b78-beef-9bcf16b8c7f7@intel.com \
--to=jingqi.liu@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome