Re: [PATCH v2 1/2] x86/mce: Add CPU_SUP_* dependencies for Intel/Zhaoxin MCE features

[Sohil Mehta <sohil.mehta@intel.com>]

On 11/13/2026 9:59 AM, Vincent Mailhol wrote:
> Intel-style MCE features are only used on Intel and Zhaoxin CPUs.  Gate
> X86_MCE_INTEL on CPU_SUP_INTEL || CPU_SUP_ZHAOXIN.
> 
> Update the prompt and help text to mention both supported CPU vendors.
> 

Can we add a little bit more on why this change is needed? Is it mainly
correcting user visible documentation or to reduce the built kernel size?

> Signed-off-by: Vincent Mailhol <mailhol@kernel.org>
> ---
>  arch/x86/Kconfig | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 58dce0b66179..91b3bc7deafd 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1158,10 +1158,10 @@ config X86_MCELOG_LEGACY
>  
>  config X86_MCE_INTEL
>  	def_bool y
> -	prompt "Intel MCE features"
> -	depends on X86_MCE && X86_LOCAL_APIC
> +	prompt "Intel and Zhaoxin MCE features"
> +	depends on X86_MCE && X86_LOCAL_APIC && (CPU_SUP_INTEL || CPU_SUP_ZHAOXIN)
>  	help
> -	  Additional support for intel specific MCE features such as
> +	  Additional support for Intel and Zhaoxin MCE features such as
>  	  the thermal monitor.

The thermal monitor is no longer part of X86_MCE_INTEL since commit
9223d0dccb8f ("thermal: Move therm_throt there from x86/mce"). If we are
correcting this entry then can we remove the reference to the thermal
monitor?

>  
>  config X86_MCE_AMD
> 

config X86_MCE_AMD
	def_bool y
	prompt "AMD MCE features"
	depends on X86_MCE && X86_LOCAL_APIC
	help

The next entry looks slightly odd after the change. I was wondering why
the AMD one doesn't need to depend on any CPU_SUP_* whereas the Intel
one does?