From: Andrew Lunn <andrew@lunn.ch>
To: Jie Luo <quic_luoj@quicinc.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Lei Wei <quic_leiwei@quicinc.com>,
Suruchi Agarwal <quic_suruchia@quicinc.com>,
Pavithra R <quic_pavir@quicinc.com>,
Simon Horman <horms@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-hardening@vger.kernel.org,
quic_kkumarcs@quicinc.com, quic_linchen@quicinc.com,
srinivas.kandagatla@linaro.org, bartosz.golaszewski@linaro.org,
john@phrozen.org
Subject: Re: [PATCH net-next v3 04/14] net: ethernet: qualcomm: Initialize PPE buffer management for IPQ9574
Date: Thu, 6 Mar 2025 16:29:20 +0100 [thread overview]
Message-ID: <74f89e1e-c440-42cb-9d8e-be213a3d83a4@lunn.ch> (raw)
In-Reply-To: <cffdd8e8-76bc-4424-8cdb-d48f5010686d@quicinc.com>
> Thanks for the suggestion. Just to clarify, we preferred
> u32p_replace_bits() over FIELD_PREP() because the former does
> a clear-and-set operation against a given mask, where as with
> FIELD_PREP(), we need to clear the bits first before we use the
> macro and then set it. Due to this, we preferred using
> u32_replace_bits() since it made the macro definitions to modify
> the registers simpler. Given this, would it be acceptable to
> document u32p_replace_bits() better, as it is already being used
> by other drivers as well?
I suggest you submit a patch to those who maintain that file and see
what they say.
But maybe also look at how others are using u32p_replace_bits() and
should it be wrapped up in a macro? FIELD_MOD()? These macros do a lot
of build time checking that you are not overflowing the type. It would
be good to have that to catch bugs at build time, rather than years
later at runtime.
Andrew
next prev parent reply other threads:[~2025-03-06 15:29 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-09 14:29 [PATCH net-next v3 00/14] Add PPE driver for Qualcomm IPQ9574 SoC Luo Jie
2025-02-09 14:29 ` [PATCH net-next v3 01/14] dt-bindings: net: Add PPE " Luo Jie
2025-02-10 2:47 ` Jie Gan
2025-02-11 14:02 ` Jie Luo
2025-02-09 14:29 ` [PATCH net-next v3 02/14] docs: networking: Add PPE driver documentation " Luo Jie
2025-02-10 2:15 ` Bagas Sanjaya
2025-02-11 12:36 ` Lei Wei
2025-02-09 14:29 ` [PATCH net-next v3 03/14] net: ethernet: qualcomm: Add PPE driver for " Luo Jie
2025-02-10 2:12 ` Jie Gan
2025-02-11 13:04 ` Andrew Lunn
2025-02-12 1:49 ` Jie Gan
2025-02-11 13:58 ` Jie Luo
2025-02-12 1:58 ` Jie Gan
2025-02-14 6:09 ` Jie Luo
2025-02-09 14:29 ` [PATCH net-next v3 04/14] net: ethernet: qualcomm: Initialize PPE buffer management for IPQ9574 Luo Jie
2025-02-11 13:14 ` Andrew Lunn
2025-02-19 13:00 ` Jie Luo
2025-02-11 13:22 ` Andrew Lunn
2025-02-20 14:38 ` Jie Luo
2025-02-20 15:09 ` Andrew Lunn
2025-03-06 10:01 ` Jie Luo
2025-03-06 15:29 ` Andrew Lunn [this message]
2025-03-11 10:44 ` Jie Luo
2025-02-09 14:29 ` [PATCH net-next v3 05/14] net: ethernet: qualcomm: Initialize PPE queue " Luo Jie
2025-02-09 14:29 ` [PATCH net-next v3 06/14] net: ethernet: qualcomm: Initialize the PPE scheduler settings Luo Jie
2025-02-11 13:32 ` Andrew Lunn
2025-02-20 14:50 ` Jie Luo
2025-02-20 15:12 ` Andrew Lunn
2025-02-28 15:24 ` Jie Luo
2025-02-09 14:29 ` [PATCH net-next v3 07/14] net: ethernet: qualcomm: Initialize PPE queue settings Luo Jie
2025-02-09 14:29 ` [PATCH net-next v3 08/14] net: ethernet: qualcomm: Initialize PPE service code settings Luo Jie
2025-02-09 14:29 ` [PATCH net-next v3 09/14] net: ethernet: qualcomm: Initialize PPE port control settings Luo Jie
2025-02-09 14:29 ` [PATCH net-next v3 10/14] net: ethernet: qualcomm: Initialize PPE RSS hash settings Luo Jie
2025-02-09 14:29 ` [PATCH net-next v3 11/14] net: ethernet: qualcomm: Initialize PPE queue to Ethernet DMA ring mapping Luo Jie
2025-02-09 14:29 ` [PATCH net-next v3 12/14] net: ethernet: qualcomm: Initialize PPE L2 bridge settings Luo Jie
2025-02-09 14:29 ` [PATCH net-next v3 13/14] net: ethernet: qualcomm: Add PPE debugfs support for PPE counters Luo Jie
2025-02-11 13:55 ` Andrew Lunn
2025-02-14 7:53 ` Jie Luo
2025-02-14 14:02 ` Andrew Lunn
2025-02-18 11:16 ` Jie Luo
2025-02-09 14:29 ` [PATCH net-next v3 14/14] MAINTAINERS: Add maintainer for Qualcomm PPE driver Luo Jie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74f89e1e-c440-42cb-9d8e-be213a3d83a4@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=bartosz.golaszewski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=gustavoars@kernel.org \
--cc=horms@kernel.org \
--cc=john@phrozen.org \
--cc=kees@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=quic_kkumarcs@quicinc.com \
--cc=quic_leiwei@quicinc.com \
--cc=quic_linchen@quicinc.com \
--cc=quic_luoj@quicinc.com \
--cc=quic_pavir@quicinc.com \
--cc=quic_suruchia@quicinc.com \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®