From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1750955AbdAWX0W (ORCPT <rfc822;w@1wt.eu>);
        Mon, 23 Jan 2017 18:26:22 -0500
Received: from mx1.redhat.com ([209.132.183.28]:54154 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750710AbdAWX0U (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 23 Jan 2017 18:26:20 -0500
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From: David Howells <dhowells@redhat.com>
In-Reply-To: <dc421c4f-4842-4429-1b99-92865c2f24b6@infradead.org>
References: <dc421c4f-4842-4429-1b99-92865c2f24b6@infradead.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: dhowells@redhat.com, LKML <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>, linux-am33-list@redhat.com,
        kbuild test robot <fengguang.wu@intel.com>
Subject: Re: [PATCH] mn10300: fix build error of missing fpu_save()
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7501.1485213978.1@warthog.procyon.org.uk>
Date: Mon, 23 Jan 2017 23:26:18 +0000
Message-ID: <7502.1485213978@warthog.procyon.org.uk>
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 23 Jan 2017 23:26:21 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Randy Dunlap <rdunlap@infradead.org> wrote:

> b. make <asm/switch_to.h> know about CONFIG_FPU not enabled
> 
> David, which one do you prefer?

b.

> From: Randy Dunlap <rdunlap@infradead.org>
> 
> When CONFIG_FPU is not enabled on arch/mn10300, <asm/switch_to.h>
> causes a build error with a call to fpu_save():
> 
> kernel/built-in.o: In function `.L410':
> core.c:(.sched.text+0x28a): undefined reference to `fpu_save'
> 
> Fix this by defining switch_fpu() in <asm/switch_to.h> only when
> CONFIG_FPU is enabled.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Cc:	David Howells <dhowells@redhat.com>
> ---
>  arch/mn10300/include/asm/switch_to.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- lnx-410-rc4.orig/arch/mn10300/include/asm/switch_to.h
> +++ lnx-410-rc4/arch/mn10300/include/asm/switch_to.h
> @@ -16,7 +16,7 @@
>  struct task_struct;
>  struct thread_struct;
>  
> -#if !defined(CONFIG_LAZY_SAVE_FPU)
> +#if defined(CONFIG_FPU) && !defined(CONFIG_LAZY_SAVE_FPU)
>  struct fpu_state_struct;
>  extern asmlinkage void fpu_save(struct fpu_state_struct *);
>  #define switch_fpu(prev, next)						\

Reviewed-by: David Howells <dhowells@redhat.com>