From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3EACEE0211 for ; Wed, 13 Sep 2023 23:00:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233082AbjIMXAn convert rfc822-to-8bit (ORCPT ); Wed, 13 Sep 2023 19:00:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229455AbjIMXAl (ORCPT ); Wed, 13 Sep 2023 19:00:41 -0400 Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EA121BCB for ; Wed, 13 Sep 2023 16:00:37 -0700 (PDT) Received: from omf15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 042DC16037F; Wed, 13 Sep 2023 23:00:35 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf15.hostedemail.com (Postfix) with ESMTPA id 9D31518; Wed, 13 Sep 2023 23:00:33 +0000 (UTC) Message-ID: <7502c1de6c25668699db7ca557f4cd61f2f1eab6.camel@perches.com> Subject: Re: [PATCH 2/2] checkpatch: Add a couple new alloc functions to alloc with multiplies check From: Joe Perches To: "Gustavo A. R. Silva" , Andrew Morton , Andy Whitcroft , Dwaipayan Ray , Lukas Bulwahn Cc: Gustavo Silva , linux-kernel@vger.kernel.org Date: Wed, 13 Sep 2023 16:00:32 -0700 In-Reply-To: <8cf58a8a-5410-4d3f-eb1a-e5bb6ce36023@embeddedor.com> References: <968f8168-1a0f-c916-86fb-fe4d89bb6250@embeddedor.com> <5d5e987a4a1a624f1d8a99a2b7f76c7c3db70241.camel@perches.com> <9ea1b028-8ac7-61b0-90e2-d240d52aaffb@embeddedor.com> <7a9f7631b7352d7f9ce07bdc53cfc92065cb11a3.camel@perches.com> <8cf58a8a-5410-4d3f-eb1a-e5bb6ce36023@embeddedor.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-Rspamd-Queue-Id: 9D31518 X-Rspamd-Server: rspamout06 X-Stat-Signature: dz4aci8mf9tgqfdabypxuzqoah1gfemf X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1+KhPP60qYqRbsmcOZX3hGgeutUfWN9CzU= X-HE-Tag: 1694646033-589595 X-HE-Meta: U2FsdGVkX18snOFVXjDMAo0zPcilYn4Y2Lwte1E86bZ5iuGLoqOC1GZVzEXyQlu9MXnwQAvAJTPkpNA9lW2BLAJbsC9v2pGw4mEeGhik0MeqH3w4Gm+/WT5QEJ4FsTvcZynWdAYdSarR6Lfve/Nin8/A95Nzuatb/w1X71ksaggHsLVVvKPkrju8ajNFIRkRyCpZPxWlXsRcfKi+HnRXGWj48pgS0AdwQtNmlDPJtxjuoIZRen1Prd+uyZUIvVfmfR7DZkny+pDpCy0oBBEssmH/AQ7XzRnZLIqIx9SnVlmY0YbX2i+il16SY4Fb0gkcZU0zurfC8AhOlzQOUOq7cx70zkWNJUuCWHoMGO76sIzEEgKFb/PJwXJOsZdyPuxGjEdb/so6cs8187agb46Y+A== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2023-09-13 at 16:41 -0600, Gustavo A. R. Silva wrote: > > On 9/13/23 16:34, Joe Perches wrote: > > On Wed, 2023-09-13 at 16:32 -0600, Gustavo A. R. Silva wrote: > > > > > > On 9/13/23 16:25, Joe Perches wrote: > > > > On Wed, 2023-09-13 at 16:14 -0600, Gustavo A. R. Silva wrote: > > > > > > > > > > On 9/13/23 14:37, Joe Perches wrote: > > > > > > vmalloc() and vzalloc() functions have now 2-factor multiplication > > > > > > argument forms vmalloc_array() and vcalloc(), correspondingly. > > > > > > > > > > > > Add alloc-with-multiplies checks for these new functions. > > > > > > > > > > > > Simplify the original codes repeated else to use a hash. > > > > > > > > > > > > Link: https://github.com/KSPP/linux/issues/342 > > > > > > > > > > > > Original-patch-by: Gustavo A. R. Silva > > > > > > > > > > Why don't you wait for a response or a v2 from the original > > > > > submitter? > > > > > > > > Because there really is no need to wait. > > > > > > By the way, did you test it? > > > > Yes, against arch/s390/include/asm/idals.h > > I don't see any instances of vmalloc() or vzalloc() in that file. Cute. Missing a ? in the original search '\s*,?' or just its removal... Likely the removal would be better. thanks, cheers, Joe