mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: Kuan-Wei Chiu <visitorckw@gmail.com>,
	ray.huang@amd.com, gautham.shenoy@amd.com, perry.yuan@amd.com
Cc: jserv@ccns.ncku.edu.tw, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools/power/x86/amd_pstate_tracer: Fix python gnuplot package names
Date: Mon, 25 Aug 2025 16:25:58 -0500	[thread overview]
Message-ID: <75046094-d3b7-49da-af8e-3747ae9ed272@amd.com> (raw)
In-Reply-To: <20250824200902.163745-1-visitorckw@gmail.com>

On 8/24/2025 3:09 PM, Kuan-Wei Chiu wrote:
> The prerequisites section listed non-existent packages
> "phython-gnuplot" and "phython3-gnuplot", which may mislead users and
> cause installation failures.
> 
> Update the names to the correct distribution package names
> "python-gnuplot" and "python3-gnuplot", helping users avoid confusion
> and saving time for those following the instructions.
> 
> Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

> ---
>   tools/power/x86/amd_pstate_tracer/amd_pstate_trace.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/power/x86/amd_pstate_tracer/amd_pstate_trace.py b/tools/power/x86/amd_pstate_tracer/amd_pstate_trace.py
> index feb9f9421c7b..875b086550d1 100755
> --- a/tools/power/x86/amd_pstate_tracer/amd_pstate_trace.py
> +++ b/tools/power/x86/amd_pstate_tracer/amd_pstate_trace.py
> @@ -11,7 +11,7 @@ Prerequisites:
>       gnuplot 5.0 or higher
>       gnuplot-py 1.8 or higher
>       (Most of the distributions have these required packages. They may be called
> -     gnuplot-py, phython-gnuplot or phython3-gnuplot, gnuplot-nox, ... )
> +     gnuplot-py, python-gnuplot or python3-gnuplot, gnuplot-nox, ... )
>   
>       Kernel config for Linux trace is enabled
>   


  reply	other threads:[~2025-08-25 21:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-24 20:09 Kuan-Wei Chiu
2025-08-25 21:25 ` Mario Limonciello [this message]
2025-09-23 16:21   ` Kuan-Wei Chiu
2025-09-23 18:44     ` Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75046094-d3b7-49da-af8e-3747ae9ed272@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=gautham.shenoy@amd.com \
    --cc=jserv@ccns.ncku.edu.tw \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=perry.yuan@amd.com \
    --cc=ray.huang@amd.com \
    --cc=visitorckw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®