From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47CC937CD59 for ; Fri, 26 Jun 2026 09:46:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.118.77.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782467196; cv=none; b=SInLXo6qkWTY49804VIGaRG9AIgLExGFRnEUdE6cMMkTnU2oebHY30NktaDrP7kKkKCx1zbtlmEU7KXQ2xyvpImeFXrL0qpDp+8glZO2yS9RBUHOi5uxFjyZUQVNKbsq3siRIawXwQu3sKEqbU6IqfGA5CozunQxF5SLcqs9ssA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782467196; c=relaxed/simple; bh=oisu7zR0v38Y828rHjRNScoVsE+KgSpp45xewOkjlQU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:In-Reply-To: Content-Type:References; b=Br8LjtoDQdtaOAAGkPW4A1sDU/ppDu5iQlf4KcZBxZh7sTMBg2eNoDrKdzvNPzyDqr/olsBXyefjNdWa2C8PHvcwxewwydHk2Qj8516IH7vA+FNKjrzBTiNiV31k4u64aGsmaB9m7jze1zmO4VqJItPLw1ScOZykDiK9UWvf8hU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=THusoym3; arc=none smtp.client-ip=210.118.77.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="THusoym3" Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20260626094632euoutp010997c0ef08d2c68328244c0a62268c81~8mHfAtIRt2463424634euoutp01T for ; Fri, 26 Jun 2026 09:46:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20260626094632euoutp010997c0ef08d2c68328244c0a62268c81~8mHfAtIRt2463424634euoutp01T DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1782467192; bh=8uVPoGobuqUzzib+j+IavUKdevfV4LK7AEjzXVVlfJI=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=THusoym3AQEp+Cp/GfVMABZpu86o8fbmByBzeBK0MT+XkyCaBP8ajZXvZJR/5Uc/b elqjf7hiYD5JLKQbCNh2bycoUmiOCkAFfdpzrgvcKuQwV8IcV3KKYMwi+/Qfp69RzN +jeR/rlOpWaUfFGDsLiXBBAD03b4apuXMzG3ifRE= Received: from eusmtip1.samsung.com (unknown [203.254.199.221]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20260626094632eucas1p2a0bd78e844ebe4e0205a0b900f8e3289~8mHemOR-Z2319923199eucas1p2t; Fri, 26 Jun 2026 09:46:32 +0000 (GMT) Received: from [106.210.134.192] (unknown [106.210.134.192]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20260626094631eusmtip16a3e68a99088c6511be0c08558f47356~8mHeBvm7K2611326113eusmtip1K; Fri, 26 Jun 2026 09:46:31 +0000 (GMT) Message-ID: <750856c8-ac82-4d05-9c8e-702d091e930f@samsung.com> Date: Fri, 26 Jun 2026 11:46:30 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Betterbird (Windows) Subject: Re: [PATCH] clk: qcom: regmap-phy-mux: Rework the implementation To: Dmitry Baryshkov , Bjorn Andersson Cc: Michael Turquette , Stephen Boyd , Taniya Das , Jagadeesh Kona , Konrad Dybcio , usb4-upstream@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio Content-Language: en-US From: Marek Szyprowski In-Reply-To: Content-Transfer-Encoding: 7bit X-CMS-MailID: 20260626094632eucas1p2a0bd78e844ebe4e0205a0b900f8e3289 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20260626094632eucas1p2a0bd78e844ebe4e0205a0b900f8e3289 X-EPHeader: CA X-CMS-RootMailID: 20260626094632eucas1p2a0bd78e844ebe4e0205a0b900f8e3289 References: <20260409-topic-phy_fastclk-v1-1-6b4aaee56b90@oss.qualcomm.com> <178093139446.244194.9422100472802070367.b4-ty@kernel.org> On 11.06.2026 21:38, Dmitry Baryshkov wrote: > On Mon, Jun 08, 2026 at 10:09:55AM -0500, Bjorn Andersson wrote: >> On Thu, 09 Apr 2026 13:57:45 +0200, Konrad Dybcio wrote: >>> The sole reason this hw exists is to let the branch clock downstream of >>> it keep running, with the PHY disengaged. This is not possible with the >>> current implementation, as the enabled status is hijacked to mean >>> "enabled" = "use fast/PHY source" and "disabled" = "use XO source". >>> >>> This is an issue, since the mux enable state follows that of the child >>> branch, making the desired "child enabled, MUX @ XO" combination >>> impossible. >>> >>> [...] >> Applied, thanks! >> >> [1/1] clk: qcom: regmap-phy-mux: Rework the implementation >> commit: e108373c54fbc844b7f541c6fd7ecb31772afd3c > This breaks at PCIe at least on SM8350. The attached WiFi card is > not detected anymore. Rewerting the patch makes it work again. Same on QCS6490-based RubikPi3, after this patch the XHCI USB host controller PCI devive is no longer detected. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland