From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751158AbdALOFF (ORCPT <rfc822;w@1wt.eu>);
        Thu, 12 Jan 2017 09:05:05 -0500
Received: from mail-lf0-f65.google.com ([209.85.215.65]:32824 "EHLO
        mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750947AbdALOFD (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 12 Jan 2017 09:05:03 -0500
Subject: Re: [RFC PATCH V2] x86: call smp vmxoff in smp stop
To: Xishi Qiu <qiuxishi@huawei.com>, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
        the arch/x86 maintainers <x86@kernel.org>, wanpeng.li@hotmail.com,
        Andrew Morton <akpm@linux-foundation.org>,
        hidehiro.kawai.ez@hitachi.com
References: <586CCA5A.8050607@huawei.com> <586DA529.1040803@huawei.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Fengtiantian <fengtiantian@huawei.com>, Xiexiuqi <xiexiuqi@huawei.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <750d6389-a128-71dc-87ff-6f557d7fbcd4@redhat.com>
Date: Thu, 12 Jan 2017 14:55:20 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <586DA529.1040803@huawei.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 05/01/2017 02:45, Xishi Qiu wrote:
> From: f00186668 <fengtiantian@huawei.com>
> 
> We need to disable VMX on all CPUs before stop cpu when OS panic,
> otherwisewe risk hanging up the machine, because the CPU ignore INIT
> signals when VMX is enabled. In kernel mainline this issue existence.
> 
> Signed-off-by: f00186668 <fengtiantian@huawei.com>

Looks good, but you need to put your colleague's real name (Tiantian
Feng?) in the Signed-off-by line, and you need another Signed-off-by
line for yourself.

Thanks,

Paolo

> ---
>  arch/x86/kernel/smp.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/x86/kernel/smp.c b/arch/x86/kernel/smp.c
> index 68f8cc2..b574d55 100644
> --- a/arch/x86/kernel/smp.c
> +++ b/arch/x86/kernel/smp.c
> @@ -33,6 +33,7 @@
>  #include <asm/mce.h>
>  #include <asm/trace/irq_vectors.h>
>  #include <asm/kexec.h>
> +#include <asm/virtext.h>
>  
>  /*
>   *	Some notes on x86 processor bugs affecting SMP operation:
> @@ -162,6 +163,7 @@ static int smp_stop_nmi_callback(unsigned int val, struct pt_regs *regs)
>  	if (raw_smp_processor_id() == atomic_read(&stopping_cpu))
>  		return NMI_HANDLED;
>  
> +	cpu_emergency_vmxoff();
>  	stop_this_cpu(NULL);
>  
>  	return NMI_HANDLED;
> @@ -174,6 +176,7 @@ static int smp_stop_nmi_callback(unsigned int val, struct pt_regs *regs)
>  asmlinkage __visible void smp_reboot_interrupt(void)
>  {
>  	ipi_entering_ack_irq();
> +	cpu_emergency_vmxoff();
>  	stop_this_cpu(NULL);
>  	irq_exit();
>  }
>