From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08993C77B7D for ; Sat, 13 May 2023 14:46:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237425AbjEMOqJ convert rfc822-to-8bit (ORCPT ); Sat, 13 May 2023 10:46:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232082AbjEMOqG (ORCPT ); Sat, 13 May 2023 10:46:06 -0400 Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 943753A9B; Sat, 13 May 2023 07:46:05 -0700 (PDT) Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.95) with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1pxqVR-003IIv-Jq; Sat, 13 May 2023 16:45:57 +0200 Received: from dynamic-077-013-140-028.77.13.pool.telefonica.de ([77.13.140.28] helo=[192.168.1.11]) by inpost2.zedat.fu-berlin.de (Exim 4.95) with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1pxqVR-000xpB-D8; Sat, 13 May 2023 16:45:57 +0200 Message-ID: <750f11848a647831ccfd1284ad0a8dd540c8f886.camel@physik.fu-berlin.de> Subject: Re: [PATCH 1/2] sh: dma: fix `dmaor_read_reg`/`dmaor_write_reg` macros From: John Paul Adrian Glaubitz To: Artur Rojek , Geert Uytterhoeven Cc: Yoshinori Sato , Rich Felker , Rafael Ignacio Zurita , linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sat, 13 May 2023 16:45:56 +0200 In-Reply-To: <309305917494c5a6c7cfb7ecb8bbf766@artur-rojek.eu> References: <20230506141703.65605-1-contact@artur-rojek.eu> <20230506141703.65605-2-contact@artur-rojek.eu> <65f873585db0cd9f79a84eb48707413775a9ba5b.camel@physik.fu-berlin.de> <2f73b2ac1ec15a6b0f78d8d3a7f12266@artur-rojek.eu> <309305917494c5a6c7cfb7ecb8bbf766@artur-rojek.eu> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.48.1 MIME-Version: 1.0 X-Original-Sender: glaubitz@physik.fu-berlin.de X-Originating-IP: 77.13.140.28 X-ZEDAT-Hint: PO Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Artur! On Sat, 2023-05-13 at 13:41 +0200, Artur Rojek wrote: > Yikes! > If this series hasn't been merged yet, perhaps we could fix this issue > in v2. I have something like this in mind (untested): > (...) > Otherwise, I'll send it in separately. Of course we'll also need to fix > `SH_DMAC_BASE1` so that it's set only for SoCs that feature two DMAC > modules... No worries, nothing has been merged yet. For one, the merge windows for 6.4 has been closed and I also haven't merged your patches into my tree yet. Please take your time to spin up a v2 of your patch set and test them properly. Maybe you're also interested in the clean-up that Geert suggested in this thread (ordering of the CPU subtypes and capitalization issues)? Also, can you write "processor manual" instead of "PM" in the other patch as well as don't use backticks for the macro names? In fact, I would suggest retitling the subject to: sh: dma: Fix dmaor_read_reg() and dmaor_write_reg() macros Oh, and I will retest your v2 patches before merging them, of course ;-). Thanks, Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913