From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E989CCA47A for ; Thu, 16 Jun 2022 13:04:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376758AbiFPNEu convert rfc822-to-8bit (ORCPT ); Thu, 16 Jun 2022 09:04:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229838AbiFPNEs (ORCPT ); Thu, 16 Jun 2022 09:04:48 -0400 Received: from sender4-of-o58.zoho.com (sender4-of-o58.zoho.com [136.143.188.58]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16DE01B7BB; Thu, 16 Jun 2022 06:04:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655384676; cv=none; d=zohomail.com; s=zohoarc; b=DG1FqeTeVL+wjeISF/i01I/jgl1+9NDEpc9gl5DZUTC8/w0GqDG3UoTre39qU4KU+UNOElTCNEawNyk32+uOs2yvc7nkJD/F/wBs9qGMXpmtmlRfJGVoYhu5HdwG++OM9EJ1r7Fl++1NlrWeQ1IztciiAxarA5oZogGePF2+E9w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655384676; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=PFS7saCV56LsgeaZyyzb6sVjUdji4Q/xacbTMRqaUnM=; b=mdMRqj2QSgo+8iAITX9x/uZVN65DOtoBZdfuQ//4XnLhOyv6uOeEkBUkm5+GiFUigUFUTJhAT9IrYzNlu/ToZ8QtY0ijc9K+Y7/QpwvcCzm/BRKikARGZOzGGNpPXBUdvlJM4hb+mL3xZBf8u/DBsbkvqRWPuIGTaplLgb78MEY= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass smtp.mailfrom=linux@mniewoehner.de; dmarc=pass header.from= Received: from z3r0.lan (185.31.62.161 [185.31.62.161]) by mx.zohomail.com with SMTPS id 1655384674238368.74023808908623; Thu, 16 Jun 2022 06:04:34 -0700 (PDT) Message-ID: <75124ab23f2c845d8f683d7e3123de3ccdb07ad0.camel@mniewoehner.de> Subject: Re: [PATCH v5 10/10] tpm, tpm_tis: Enable interrupt test From: Michael =?ISO-8859-1?Q?Niew=F6hner?= To: Jarkko Sakkinen , LinoSanfilippo@gmx.de, James.Bottomley@hansenpartnership.com Cc: peterhuewe@gmx.de, jgg@ziepe.ca, stefanb@linux.vnet.ibm.com, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, l.sanfilippo@kunbus.com, lukas@wunner.de, p.rosenberger@kunbus.com In-Reply-To: References: <20220610110846.8307-1-LinoSanfilippo@gmx.de> <20220610110846.8307-11-LinoSanfilippo@gmx.de> Content-Type: text/plain; charset="UTF-8" Date: Thu, 16 Jun 2022 15:04:30 +0200 MIME-Version: 1.0 User-Agent: Evolution 3.42.2 Content-Transfer-Encoding: 8BIT X-ZohoMailClient: External Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2022-06-15 at 21:26 +0300, Jarkko Sakkinen wrote: > On Fri, Jun 10, 2022 at 01:08:46PM +0200, LinoSanfilippo@gmx.de wrote: > > From: Lino Sanfilippo > > > > The test for interrupts in tpm_tis_send() is skipped if the flag > > TPM_CHIP_FLAG_IRQ is not set. Since the current code never sets the flag > > initially the test is never executed. > > > > Fix this by setting the flag in tpm_tis_gen_interrupt() right after > > interrupts have been enabled. > > > > Signed-off-by: Lino Sanfilippo > > --- > >  drivers/char/tpm/tpm_tis_core.c | 5 +++++ > >  1 file changed, 5 insertions(+) > > > > diff --git a/drivers/char/tpm/tpm_tis_core.c > > b/drivers/char/tpm/tpm_tis_core.c > > index e5edf745fb23..be229c173f10 100644 > > --- a/drivers/char/tpm/tpm_tis_core.c > > +++ b/drivers/char/tpm/tpm_tis_core.c > > @@ -774,11 +774,16 @@ static int tpm_tis_gen_interrupt(struct tpm_chip > > *chip) > >         if (ret < 0) > >                 return ret; > >   > > +       chip->flags |= TPM_CHIP_FLAG_IRQ; > > + > >         if (chip->flags & TPM_CHIP_FLAG_TPM2) > >                 ret = tpm2_get_tpm_pt(chip, 0x100, &cap2, desc); > >         else > >                 ret = tpm1_getcap(chip, TPM_CAP_PROP_TIS_TIMEOUT, &cap, > > desc, 0); > >   > > +       if (ret) > > +               chip->flags &= ~TPM_CHIP_FLAG_IRQ; > > + > >         release_locality(chip, 0); > >   > >         return ret; > > -- > > 2.36.1 > > > > James, do you have a chance to test this on your side? Thanks. > > BR, Jarkko Tested-by: Michael Niewöhner