From: "Arnd Bergmann" <arnd@arndb.de>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
"Jeff Layton" <jlayton@kernel.org>,
"Chuck Lever" <chuck.lever@oracle.com>,
"Alexander Aring" <alex.aring@gmail.com>,
"Jan Kara" <jack@suse.cz>,
"Christian Brauner" <brauner@kernel.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfs: use UAPI types for new struct delegation definition
Date: Wed, 03 Dec 2025 15:14:31 +0100 [thread overview]
Message-ID: <75186ab2-8fc8-4ac1-aebe-a616ba75388e@app.fastmail.com> (raw)
In-Reply-To: <20251203-uapi-fcntl-v1-1-490c67bf3425@linutronix.de>
On Wed, Dec 3, 2025, at 14:57, Thomas Weißschuh wrote:
> Using libc types and headers from the UAPI headers is problematic as it
> introduces a dependency on a full C toolchain.
>
> Use the fixed-width integer types provided by the UAPI headers instead.
>
> Fixes: 1602bad16d7d ("vfs: expose delegation support to userland")
> Fixes: 4be9e04ebf75 ("vfs: add needed headers for new struct delegation
> definition")
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Acked-by: Arnd Bergmann <arnd@arndb.de>
> --- a/include/uapi/linux/fcntl.h
> +++ b/include/uapi/linux/fcntl.h
> @@ -4,11 +4,7 @@
>
> #include <asm/fcntl.h>
> #include <linux/openat2.h>
> -#ifdef __KERNEL__
> #include <linux/types.h>
> -#else
> -#include <stdint.h>
> -#endif
I think we have a couple more files that could use similar changes,
but they tend to be at a larger scale:
include/uapi/linux/fuse.h
include/uapi/linux/idxd.h
include/uapi/linux/ax25.h
include/uapi/regulator/regulator.h
include/uapi/xen/privcmd.h
Arnd
next prev parent reply other threads:[~2025-12-03 14:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 13:57 Thomas Weißschuh
2025-12-03 14:01 ` Jeff Layton
2025-12-03 14:14 ` Arnd Bergmann [this message]
2025-12-04 6:58 ` Thomas Weißschuh
2025-12-04 9:09 ` Arnd Bergmann
2025-12-04 9:02 ` Christian Brauner
2025-12-04 9:17 ` Thomas Weißschuh
2025-12-05 8:52 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75186ab2-8fc8-4ac1-aebe-a616ba75388e@app.fastmail.com \
--to=arnd@arndb.de \
--cc=alex.aring@gmail.com \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.weissschuh@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®