From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f43.google.com (mail-oa1-f43.google.com [209.85.160.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 414462EC083 for ; Thu, 19 Feb 2026 18:40:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771526443; cv=none; b=tecEERysN9FbYW0ALFOL0MM/RY6TY2AL3tfa939hSAVOT2Md2NibIYU0SG4bIm4hWUcJcvgOmHRClrjWSuYc1e5KV/NGNgomWp5mjiNtwzh9w9eSmQ+libmmIp3eO1Cxa2JkZ9UMsUYddoEQ1/IqqVbFc/Wp6U1+VOmEzPF9ecU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771526443; c=relaxed/simple; bh=fU3lA7VpwFCxes0Dr9aFEjsRGOPizP4mVR4Z4GdX+xQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jGq87/6AuYiz5dt52+P9hSfAKDu2+dQLjppDBvdta44I4GexREN+1sWWdERbn6pzGuNklk75kJnRdvBAgOy6qFkhwpS5jd/svWhxCAOZosMfRO3uGxuL4sit1mZ8WosLBO38Zwo8kaCVZ8cy7GjdGwkH6wajQBmbkqn7sjyFxQY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=1Lv24s5w; arc=none smtp.client-ip=209.85.160.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="1Lv24s5w" Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-40423dbe98bso523183fac.2 for ; Thu, 19 Feb 2026 10:40:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1771526436; x=1772131236; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9IWO5m5WHHqRoC8lS5ugD/MQKoBV1QdUD735Fcl1Kkk=; b=1Lv24s5whiUBlRS9jgCs/OjRSA/nC2s6UI48x4AQjiU0IYdsYgEHQ+6wCN6FRZiojR SM9JGUvPbH0YHuGtuzzH2I//6t9n8Vc0StttnhNEyhf0c0mSBjU9GT8iqX+aSEHCWq7H P7K8VMtw414/a2qoJ4SDmCxOewzU3t/WEIwReuxifW8KLUcUH84sfwAl4PBuDgMQX0Wn 06q8Ooxn2sPW6i+okso04nfH29TxpDV24U46QYhhMaPL/xFBTqe09jv8XcANyI7tzMfG p+UJeMlfTT0LFHEgNrkU2fFIq5rZYuCKxPTI+MwUAHdCl8G1FLm17UbEIPXKtLxTNg6s FjYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771526436; x=1772131236; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9IWO5m5WHHqRoC8lS5ugD/MQKoBV1QdUD735Fcl1Kkk=; b=ld8vxcjlLKoi+/CD/nwZw1nMrb6Fs/8uzC0PAT+jOM8c5MqQy7T+xGKePOhQ/1EGGh VnrcFNcDYbTJYZr/FohEKYhFSgqjc3rhsZDk9XJNz7NriGjYMzJ/xcvm9gdU2VxanBhd OQQKdfLnQbghUNPSdaH01EF0mhe/T3pXFq/Tdev3zW7dJZpYYRH1vjBjkNhx26VhTQxT 96eIQ54/EVZi1lY+WP+5vHA2McXlQhopw68aDMUS5MuDd8HThNnOepNmTEGW9y+d3Nvm /O7p5dycKWWvQ/RCnVzIz3NsgAaLP/YjeJ+QKY0oYkl11bVLbzT421Nlxzwd6Ipz9JNH Ge/A== X-Forwarded-Encrypted: i=1; AJvYcCVGbqZYNTynf6a5g6LM04AIvRpKbw+OvPQR/Sy90mAgP14SLOC64ZxkH7jI9nleWX49u2sN350qP0TfpBQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxlX9o5X9GfD/lzzSfw4FqiNnn1Qdn4dikHXM2NflkZ+TJMUyAl pbb9np78fS7ukBLhZNlVZIurugOVbq+EmYSzcfILI5VZ6eX1pgmE0RuLEUKEqC08XEg= X-Gm-Gg: AZuq6aLJo158OCai2lQOYgyjyLxd9kijLcncB6vZ2utg1BZv81Ng8qq7rW9CV1BivS7 LvFs6P0IyDglbGLPlhNjijaujdm5GTKRXVYPbt/eGVbSeIR89MgIkmM9EJPTzrwWbP1xz1xICaY 0RPyR1elglQqWrTvSXV7Caaae8N0sqtQtPmVyopQss6YZfmczEhUS9mI9mk0XcBlV5XTp2aUedG XhSMVHyotJJexD5RYnuBCoqOHPRL9LfayM60U1uJqK975y4jXZQMvHKveQ/gPHaXwuf9fdgX3yq eekBY7tDITz1ryc8vDuEhc6IrN6MjNT5smLLk1PUJMYNGrxALbAifEhIKIlGSUaXrN6V4t5Rk0L s4pefZYWIkn9MjxMlBKheqY3TBaflHuojIayV3cRo5uJ5bvcHTkmDUZXVMfLxj1P2rgyMSMF7eM 4q1qAH6Z6qI/wSEAGoDpL0XFzBgHr1mjzGe4UgoueYSWJ33zPVNGdl/RcZtC9mBVfsA+PtwQ5L5 92jtvUz X-Received: by 2002:a05:6870:1587:b0:409:a121:19d9 with SMTP id 586e51a60fabf-40f0d9b194dmr9062080fac.47.1771526436041; Thu, 19 Feb 2026 10:40:36 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:d4c1:bce:26a1:c903? ([2600:8803:e7e4:500:d4c1:bce:26a1:c903]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-40ee62b6f61sm21460634fac.10.2026.02.19.10.40.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Feb 2026 10:40:34 -0800 (PST) Message-ID: <751d82d2-0d03-48ed-a917-dbb0cc8a3418@baylibre.com> Date: Thu, 19 Feb 2026 12:40:33 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 06/18] clk: mediatek: Add MT8189 vlpcfg clock support To: "irving.ch.lin" , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Richard Cochran , Bartosz Golaszewski , Chen-Yu Tsai , Miles Chen Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com, Qiqi Wang , sirius.wang@mediatek.com, vince-wl.liu@mediatek.com, jh.hsu@mediatek.com References: <20260202062840.342707-1-irving-ch.lin@mediatek.com> <20260202062840.342707-7-irving-ch.lin@mediatek.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260202062840.342707-7-irving-ch.lin@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/2/26 12:28 AM, irving.ch.lin wrote: > From: Irving-CH Lin > > Add support for the MT8189 vlpcfg clock controller, > which provides clock gate control for vlp domain IPs. > > Signed-off-by: Irving-CH Lin > --- ... > +static const struct of_device_id of_match_clk_mt8189_vlpcfg[] = { > + { .compatible = "mediatek,mt8189-vlp-ao", .data = &vlpcfg_ao_reg_mcd }, > + { .compatible = "mediatek,mt8189-vlpcfg-ao", .data = &vlpcfg_reg_mcd }, These names are a bit confusing to me. I would expect vlpcfg_ao_reg_mcd to match "mediatek,mt8189-vlpcfg-ao" since they both contain "vlpcfg" and "ao" in the name. In other words, this is the naming I would expect to avoid confusion: { .compatible = "mediatek,mt8189-vlp-ao", .data = &vlp_ao_reg_mcd }, { .compatible = "mediatek,mt8189-vlpcfg-ao", .data = &vlpcfg_ao_reg_mcd }, I suspect that the same improvement could be made in the other patches in this series as well. > + { /* sentinel */ } > +}; > +