From: Arnd Bergmann <arnd@arndb.de>
To: Kevin Cernekee <cernekee@gmail.com>
Cc: grant.likely@linaro.org, kbuild-all@01.org,
gregkh@linuxfoundation.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] m32r: Add missing big-endian I/O accessors
Date: Thu, 27 Nov 2014 18:52:58 +0100 [thread overview]
Message-ID: <75201216.LyHlPqmjDS@wuerfel> (raw)
In-Reply-To: <1417110404-13297-2-git-send-email-cernekee@gmail.com>
On Thursday 27 November 2014 09:46:44 Kevin Cernekee wrote:
> #define iowrite32 writel
>
> +#define ioread16be(addr) be16_to_cpu(readw(addr))
> +#define ioread32be(addr) be32_to_cpu(readl(addr))
> +#define iowrite16be(val, addr) writew(cpu_to_be16(val), addr)
> +#define iowrite32be(val, addr) writel(cpu_to_be32(val), addr)
> +
>
m32r can be either little-endian or big-endian, so these need to
unconditionally swap instead.
Arnd
prev parent reply other threads:[~2014-11-27 17:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 17:46 [PATCH 1/2] m32r: Fix ioread8 definition Kevin Cernekee
2014-11-27 17:46 ` [PATCH 2/2] m32r: Add missing big-endian I/O accessors Kevin Cernekee
2014-11-27 17:52 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75201216.LyHlPqmjDS@wuerfel \
--to=arnd@arndb.de \
--cc=cernekee@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome