From: Ziyuan Xu <xzy.xu@rock-chips.com>
To: Shawn Lin <shawn.lin@rock-chips.com>,
Heiko Stuebner <heiko@sntech.de>,
Rob Herring <robh+dt@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mmc@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2 4/4] clk: rockchip: remove CLK_IGNORE_UNUSED flag for aclk_emmc_grf on rk3399
Date: Wed, 31 Aug 2016 11:15:18 +0800 [thread overview]
Message-ID: <7520496e-890c-1f60-6c44-c71ed7c97ad9@rock-chips.com> (raw)
In-Reply-To: <1472607448-4462-5-git-send-email-shawn.lin@rock-chips.com>
On 2016年08月31日 09:37, Shawn Lin wrote:
> aclk_emmc_grf is used for accessing corecfg_* of emmc stuff within
> GRF block. We don't need to add CLK_IGNORE_UNUSED for it now as the
> emmc driver will enable/disable it explicitly when needed.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
This patchset test result:
localhost driver # cat /sys/kernel/debug/clk/clk_summary | grep emmc
gpll_aclk_emmc_src 1 1
594000000 0 0
aclk_emmc 3 5
198000000 0 0
aclk_emmcgrf 1 2
198000000 0 0
aclk_emmc_noc 1 1
198000000 0 0
aclk_emmccore 0 0
198000000 0 0
clk_emmc 1 2
148500000 0 0
emmc_cardclock 0 0
148500000 0 0
cpll_aclk_emmc_src 0 0
800000000 0 0
After unbind driver.
localhost driver # cat /sys/kernel/debug/clk/clk_summary | grep emmc
gpll_aclk_emmc_src 1 1
594000000 0 0
aclk_emmc 1 2
198000000 0 0
aclk_emmcgrf 0 0
198000000 0 0
aclk_emmc_noc 1 1
198000000 0 0
aclk_emmccore 0 0
198000000 0 0
clk_emmc 0 0
148500000 0 0
cpll_aclk_emmc_src 0 0
800000000 0 0
And aclk_emmcgrf(Bit 10, when high, enable clock) had gate.
localhost driver # mem r 0xff760380
0x00000415
It works sane, so
Tested-by: Ziyuan Xu <xzy.xu@rock-chips.com>
> ---
>
> Changes in v2: None
>
> drivers/clk/rockchip/clk-rk3399.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/rockchip/clk-rk3399.c b/drivers/clk/rockchip/clk-rk3399.c
> index ede6c47..908f684 100644
> --- a/drivers/clk/rockchip/clk-rk3399.c
> +++ b/drivers/clk/rockchip/clk-rk3399.c
> @@ -934,7 +934,7 @@ static struct rockchip_clk_branch rk3399_clk_branches[] __initdata = {
> RK3399_CLKGATE_CON(32), 8, GFLAGS),
> GATE(ACLK_EMMC_NOC, "aclk_emmc_noc", "aclk_emmc", CLK_IGNORE_UNUSED,
> RK3399_CLKGATE_CON(32), 9, GFLAGS),
> - GATE(ACLK_EMMC_GRF, "aclk_emmcgrf", "aclk_emmc", CLK_IGNORE_UNUSED,
> + GATE(ACLK_EMMC_GRF, "aclk_emmcgrf", "aclk_emmc", 0,
> RK3399_CLKGATE_CON(32), 10, GFLAGS),
>
> /* perilp0 */
prev parent reply other threads:[~2016-08-31 3:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 1:37 [PATCH v2 0/4] Control clock for accessing syscon provided by arasan IP Shawn Lin
2016-08-31 1:37 ` [PATCH v2 1/4] Documentation: mmc: sdhci-of-arasan: Add clk_syscon as an optional one Shawn Lin
2016-08-31 1:37 ` [PATCH v2 2/4] mmc: sdhci-of-arasan: Control clock for accessing syscon Shawn Lin
2016-08-31 3:11 ` Ziyuan Xu
2016-09-01 13:02 ` Adrian Hunter
2016-08-31 1:37 ` [PATCH v2 3/4] arm64: dts: rockchip: add clk_syscon for sdhci on rk3399 Shawn Lin
2016-08-31 3:19 ` Ziyuan Xu
2016-08-31 1:37 ` [PATCH v2 4/4] clk: rockchip: remove CLK_IGNORE_UNUSED flag for aclk_emmc_grf " Shawn Lin
2016-08-31 3:15 ` Ziyuan Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7520496e-890c-1f60-6c44-c71ed7c97ad9@rock-chips.com \
--to=xzy.xu@rock-chips.com \
--cc=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®