From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A8472135B8 for ; Mon, 29 Dec 2025 15:49:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767023400; cv=none; b=fpK/AGc4gxvjgJOOx71MQLnTCfLYnRrsESeB1lW84tk69qSz9y7dMoITiIViRAeioYtgeSUD0lpJ2GopBczEnRg9SlojZxnUdVAoplHGvyPiqxhHE/psSyjCYV7JVGAwLwgen11c4xPY6rhQdJ0TpNEfF7GVfcZLqkNvyjL45ak= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767023400; c=relaxed/simple; bh=yMKiGiJJxuLS8kqQNhnesIoImT5Lp/V/bhJzTXfWqEQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sHq6o4i3NY4chC+pBqOK61aO4ueDDz1nWhe4KWdqSEg/YzgrQBXhxAu/k5HsgZC77Iyd2hlETKrx71PbRDQ1siA6djXtrHVQbFpehPpYYDfDEEA3ybW0iIVdpwNuEB7VPp3uJaG80+UQVTFPHlj8q5JfKHCHTXUrtd2vDXF3lT4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QDrydmid; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=SSQ+6qi8; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QDrydmid"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="SSQ+6qi8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767023397; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Yj18/my6uVxomwZqbIiVl/L5IVwA7o6fFfXKTmyhCxY=; b=QDrydmidLKRanFUfvUmFxdZonUrApCvRVcCZOjhpINA7jLZVECWapOCj+z0t4ABeeKT7wb m2+jg2zS5TNNnNuJzNdsn8z8YKkkMoDQn6H27eRkpT0lLmE/YZdVJLvk/nt7gX4NpELVDK Tz8KyPFsTDEwaQ1zye87U9zcDHjlS88= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-509-mIEpme7OOZy0vssaVkXW0A-1; Mon, 29 Dec 2025 10:49:55 -0500 X-MC-Unique: mIEpme7OOZy0vssaVkXW0A-1 X-Mimecast-MFC-AGG-ID: mIEpme7OOZy0vssaVkXW0A_1767023394 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4776079ada3so82450465e9.1 for ; Mon, 29 Dec 2025 07:49:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767023394; x=1767628194; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Yj18/my6uVxomwZqbIiVl/L5IVwA7o6fFfXKTmyhCxY=; b=SSQ+6qi8H5MvJXIhA+oW8qVOe2FmOTE/ImY7zO4uSrtsiBfgRH2Cs3RWYHkgacxbNX DqVuuc69gzWYiEqVRQEIalwR0tt2xMT58n3GTe7pD5JMZJ2dCdh5B0yjIclK/5M+/1Sj GMfF9qwrSGI1DRLKW9mcIr/R4T7AoJyqTsHe//kdY2PWwXuo13OMGfIABMfwup0kzg4s 7QsqXnGPMiKQkxWC2a6P/HDwDNCWYn/97uG4k1IgwQ8VIJXjSAjK/aJyG8KIggiF88Ej gv+m4Kr3Yq4DQdmKwUEMQ5pLS8kP95UJ8EnuTPCnQy7Y+1Tx9eyXkStubyd2ODSsc+az VQQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767023394; x=1767628194; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Yj18/my6uVxomwZqbIiVl/L5IVwA7o6fFfXKTmyhCxY=; b=t1uO4g5JLy1iSgs8s0XaeRpOXH2bZ3nIYCB3jir+Z6IPtVFDih8EIfJveAnFAzpve+ K4iq8SqYk/ovdLZLIT2tNypdFgWH4UCFnVGVpurlUIAkbIYvjg73jPOFg42A7HvSekuk OT0RMpVq5nsgMpu4rxHsQCdak2qG7iUJU6S8xanpMVtESsFOH6KAj9lfT0M05vNv2TNF 6PfX2x5FfVmSh5DrrN4X61i2Fzbg09EvhZUs60Jveltoy9luaKlUZfPd9mcS929wzikf P6IH2TbaxZk7+D6z07GmTpoADQuOPwrjQBlXfrNLmU15Khze7e4XmVRDpVPVuXegtR7F SM8g== X-Forwarded-Encrypted: i=1; AJvYcCV+DrltpRTclcR5lOnfO0fyEvwprkp060w2kwe0efnQw3nAoXrXk8Dhv/cuTnxiztlbTvS+HCSXtQeQpLs=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8LZZhpKH6799uT937EFJAowZxKD8Pc4T5P6ArXs4yV8dcqZIR DRmqtFtzGAxiBBtql8+oHmX4+2js8seT1ze225V9lgVfwz/pc7uPhwHKLfr+41nyCVToHWgX1+U Q3h6ru3BxlJJDEqexnrGCpBo24xGOrCFwszJ1VEHjnl907Rjv9vCyusultF/gmR6zPg== X-Gm-Gg: AY/fxX7niMbvyiS2yPwAJc7tuVMJXdXyQxRMTh563q7CEeKVKhflScMq83M6lLuZOQL GjEcqaWmnA2Tgpt4+GiB4R09sHUqhC/NnIGbd0uvOXb4VrpWg4R9vyIwV7ssfvapBcE28vIGhRC mdGt36RmVAxKNMYM2u/bh7ogYSP2z8YFKS39PGgz+fu9wXPYtCO4XqKobjEAn8NNmobMnE3k48O s/ZMMW2PvuSasDPKfesL8e/ceetC/m8XdtEZkRfJD/Gf3cRMV7/bNqfsU2Y7e39A1AVPijG6MWd hYn+/uPdIjb91jpt6Y5CZ7ncd4kzYFF5XXn87Z4ZzeYk6tpOwxHZ/hZ6pWkQnzovc1oTEAoA23T NKa/F0hDSSNFl3A== X-Received: by 2002:a05:600c:a016:b0:477:5c45:8100 with SMTP id 5b1f17b1804b1-47d19594e57mr357663735e9.24.1767023394456; Mon, 29 Dec 2025 07:49:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IHfTpCjqyJy84kW7i8l3Woyc3392zb+r8k2GWD+lM0HDOgiT7tTmjdSbD1zCvF1lHTrSsDJRg== X-Received: by 2002:a05:600c:a016:b0:477:5c45:8100 with SMTP id 5b1f17b1804b1-47d19594e57mr357663405e9.24.1767023394077; Mon, 29 Dec 2025 07:49:54 -0800 (PST) Received: from [192.168.88.32] ([169.155.232.231]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be3a210e7sm232426785e9.3.2025.12.29.07.49.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Dec 2025 07:49:53 -0800 (PST) Message-ID: <75205c09-7adb-4770-b551-de3c4f7a2ab4@redhat.com> Date: Mon, 29 Dec 2025 16:49:51 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] octeontx2-pf: fix "UBSAN: shift-out-of-bounds error" To: Anshumali Gaur , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sunil Goutham , Geetha sowjanya , Subbaraya Sundeep , hariprasad , Bharat Bhushan , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Christina Jacob References: <20251219062226.524844-1-agaur@marvell.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20251219062226.524844-1-agaur@marvell.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/19/25 7:22 AM, Anshumali Gaur wrote: > This patch ensures that the RX ring size (rx_pending) is not > set below the permitted length. This avoids UBSAN > shift-out-of-bounds errors when users passes small or zero > ring sizes via ethtool -G. > > Fixes: d45d8979840d ("octeontx2-pf: Add basic ethtool support") > Signed-off-by: Anshumali Gaur > Change-Id: I6de6770dbc0dd952725ccd71ce521f801bc7b15b Please strip the above tag in future submissions. Thanks, Paolo