From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 696B5C77B72 for ; Thu, 20 Apr 2023 15:52:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231675AbjDTPw2 (ORCPT ); Thu, 20 Apr 2023 11:52:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233092AbjDTPwZ (ORCPT ); Thu, 20 Apr 2023 11:52:25 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD45D19AA for ; Thu, 20 Apr 2023 08:52:23 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-94a34d3812dso88434566b.3 for ; Thu, 20 Apr 2023 08:52:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682005942; x=1684597942; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6wNV6vuEnDx323qiEZUPunRODUIJ2Mg30GBaFfSSX3w=; b=KUtGBpFZ4K9dSucECVZlT2qy5FvnWxP46zuHOMVJsi91f5wQw9RmX+hqV9rMJRjNWC bvim1ZW9BruSUXh7t24xkD3E9qIDDtOL2WfURgKcM2ITYHMdr0ZBeDhuidNarsqaSc0r yqe4GJjZQs13isZMujvMrIcwjP1EtTq/AmwONYNGk84c30P61LpkPI1ihZgK/5a/kcsQ b+tH1uPgz8oc1SstFQE1V/sba0WNunH5lWfib68TvZme9Q0X4I1rsPIlqiwAowJyjdgq gP7z4PD2Y24KMaDINb0teLYR4fj+RqFRpQcUOZpkLkSVfPnN3Vau0dNrArU1iweUL6p1 +hyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682005942; x=1684597942; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6wNV6vuEnDx323qiEZUPunRODUIJ2Mg30GBaFfSSX3w=; b=b20WcCpGKsek52/fZGA8lRQ3at4jad44wJ2VRsFs23DF/l4H+rjVEIn513szoQaoTJ yy5nsfxITaE54eKFG6d5NVfo5f/CK80B5mTl1YBY+shDLJxlo0zb0dl6Ws+b6PZFBwHb PtF/zqBj2C8Xi1BJ74Zvrz/c37TEBORGGznh88hkTCu++fOTnHaDD3pwH8UmEAHuzAKm vQK5ZIdstVet6P8kPKi4wC0OuuRvzLUxvNGDDf4WJWkMdoFb5geS9BN8HHL+O34XOe0D y5ONkB167uOmV5iXSUeaqiSKK+co796cISOo+rgnHf80ffZ3RgoFIMPYRpB40Dr2XqD3 KSbQ== X-Gm-Message-State: AAQBX9c5Opm7FYqEFJM6qwUXc2WhfEIlYu0OR5+vY/uzvL9ymWET7Igw iHaIp12WCjQBg3qFMryZ2uEfCA== X-Google-Smtp-Source: AKy350aPmsWqtsiLlXtFEKjMdEfdFTHARCOQr/LjyoR6a22xRet0wGy1eSSq3Rw+P0/E+xbmTBCyWg== X-Received: by 2002:a05:6402:6d9:b0:506:833c:abcf with SMTP id n25-20020a05640206d900b00506833cabcfmr2405927edy.42.1682005942297; Thu, 20 Apr 2023 08:52:22 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:bcb8:77e6:8f45:4771? ([2a02:810d:15c0:828:bcb8:77e6:8f45:4771]) by smtp.gmail.com with ESMTPSA id k10-20020aa7c04a000000b005076635b02bsm884526edo.13.2023.04.20.08.52.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Apr 2023 08:52:21 -0700 (PDT) Message-ID: <75231886-cdf6-cfde-d6b9-183b1fbf98da@linaro.org> Date: Thu, 20 Apr 2023 17:52:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH V3 1/2] dt-bindings: interrupt-controller: Add Loongson EIOINTC Content-Language: en-US To: Binbin Zhou Cc: Binbin Zhou , Huacai Chen , WANG Xuerui , Jiaxun Yang , Thomas Gleixner , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Jianmin Lv , Huacai Chen , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, loongarch@lists.linux.dev, devicetree@vger.kernel.org, loongson-kernel@lists.loongnix.cn References: <3b9c4f05eaf14bc3b16aebec3ff84c8a2d52c4a5.1681887790.git.zhoubinbin@loongson.cn> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/04/2023 15:00, Binbin Zhou wrote: >>> +examples: >>> + - | >>> + eiointc: interrupt-controller@1fe11600 { >>> + compatible = "loongson,ls2k0500-eiointc"; >>> + reg = <0x1fe11600 0x10>, >>> + <0x1fe11700 0x10>, >>> + <0x1fe11800 0x10>, >>> + <0x1fe114c0 0x4>; >> >> Binding is OK, but are you sure you want to split the address space like >> this? It looks like two address spaces (enable+clear+status should be >> one). Are you sure this is correct? >> > Hi Krzysztof: > > These registers are all in the range of chip configuration registers, > in the case of LS2K0500, which has a base address of 0x1fe10000. > However, the individual register addresses are not contiguous with > each other, and most are distributed across modules, so I feel that > they should be listed in detail as they are used. Do you want to say that: Between 0x1fe11600 and 0x1fe11700 there are EIOINTC registers and other (independent) module registers? Best regards, Krzysztof