From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 210254D8DAD for ; Thu, 3 Sep 2026 15:21:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788448898; cv=none; b=Lr6WWPKQDSkrfnhAdlaFBiql4G0oAENnfGrHGxcIZdkKkoSSb51KXzzUV0hnZ5Jm8YawLHxR3H4/WXs2u9dpd31B8QeDp0x6VARmj/SjlJVN6IyDBRh9dHDIlnfWQ1K5BCNZ/1W8V1jt9dIPongM0aJejlnNw2RpW22maoIkJhY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788448898; c=relaxed/simple; bh=AJRmnZv8TBL24Tq4Nk/MVvTyAGNJB3SKUgQnbs7iPxY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QJVKyr2hUt7qrQDITsdoEnQui8sklE36qTtGAWD1j29xBERknck1s61iN68hoH+QuM30mV+T5veOdtHLX6CIZLGWPLgt4HjnACHXM/2/b3R+xc8138CyUClmy1E+z8j9hTlW41HungHkpdm2Xbu95Y0DIxY3NBTHSHEsKNZnx1Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VuImJggM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZRueYH86; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VuImJggM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZRueYH86" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 683DAFrG4093530 for ; Thu, 3 Sep 2026 15:21:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MDXm9sakiTVow2HHdoD2Gmx3gY3Rs3Pfdamjmd0bvo0=; b=VuImJggMuzKB4UNo 4VSWxjGM0gt7Rnn7mxvFDlGUG9Vjfux/uR55j/BDqogQzf7KWKHUgkGkxQDFV7ii EDGnXWpSAsTTwy0gK7N/X39QdokV72HJAawjGkkt2eV9NmN8NbhltQEZQRFImDlJ KdI1CHq4SFfk+9wveFkZq79j5+DHMcPjouWifhq7uTXOu+CR+beoL6JXTuSJC0Mz 16kzkMiBVK4GB6XgkCQqBc5vSixcfRPPe+CrXIBYpa3rmNjt8Nu8UDklfqF+wd5b 1PB7Nedvp2Ca5bqpSlHTbW/EcdagcwxyZVGTBykfaGXCvT1uv2BOzjVRvhRsVesW EvgsEg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gf0gjttn0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 03 Sep 2026 15:21:36 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2d54187d8b0so67936375ad.0 for ; Thu, 03 Sep 2026 08:21:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788448896; x=1789053696; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MDXm9sakiTVow2HHdoD2Gmx3gY3Rs3Pfdamjmd0bvo0=; b=ZRueYH86rn1TmmT2ZJdIZd9YFM5WjVXhCQUA1J2BgAXdY2rFch6sxz8Wnx1C2HDsbu QgQmQnAfvKxYs1VtpUlVi4HjUWTXGY77hV8JFhrbnTOeySAgwcpbEkYRPeIyCnsktHh6 6yr7+/gswwq3GKKkIj/POxhZ/d7+XdXm6a7MEWMLxS+oqY/iMRnAyR3vpD4dce94H//7 978oWQzX2/IZMvXFC1ZMGkG2gsLANTU2u8DE1MkGnGHE3I13zjFwqhJLDI8/hIBlHt2a JB0sq5IAp3EJjfUzh0CGjYxkitZNg85Wvb4BZjRgFJrCLJD4iFsnsYxJ7TdyDLDgovzX tl8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788448896; x=1789053696; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MDXm9sakiTVow2HHdoD2Gmx3gY3Rs3Pfdamjmd0bvo0=; b=Hc+3eYIMylCQ3mSdkH/2yns8w1OLojkqPdh9RqwVZ+Q5cDjqHDbwEGcPSHOm9P08Zl 2T8h6LYpzEwqTqGTdaBulG2Ym7fW2Ja2bxEPAMd5X8WeqL5e+uIqE5QLPKbMG/2EVD8h kV9pI3ldsu6GqJJ13RAXPqxUv8WhkK8hpO3IsoPNfvfSt8oLL8GoAogFz6MvG7WSfJTS 0pYxYu/gII3gZM+bA8E/BXOhIB4Vak/YIyVQsWpicG3ajz8LEUsJq90U5bNb2tC/8D8O Riw2oU0i6Ab/qgfensx7KZfc44DyYGVq3yjCu3QhiRPlep1kVizk3YFEU598arx3Qcyn RzQQ== X-Forwarded-Encrypted: i=1; AKwUvBwnuyNSBkGIqr/7MoKTvcu5tUiITd/Hj9td3xHvzZJSIcUT6EJWlcRp9pGzGh9vUpxhPaj8hTJlS0ULQ4U=@vger.kernel.org X-Gm-Message-State: AFuF++n4chrC80Td80KIdRzylBRpIEG/EE/IpZ1RquELoljPhT7ANmCS 4Lmq3YS7ya/c7HHZYHtgdzMZ8gr98f7w+5cxrWwRg8AzZQnQiNWCmHl+Dxhm4sKqPfA/unLXDI7 PcLB3wYLz+k4Gwi23VKCObikzAKzMVAszsOa3CXptVINNkaaLuVHeVdKkxhKvTV2OzWE= X-Gm-Gg: AYBFou24r3Ir7n76yOIQ0LZwa1pXkzbG+arBL/1fNM5r29RFxQcbtIwwUb34nY+FbM/ Kx4129ehQeQagVUZtUHVhwA3gXs84Kp/LY3/Ka15WP1C0PlS+c3EXWzM3vRHSjEiQVzuDsN8pMe /7kcUvRmY+HmrXsYAbT+6Ehtv+/ZkJgscubyFun+78MiB/OSFdCEjX9qZS7piGpJSAHzWj6+HKC m5iu30Ikd7QU8o5YhnIZCRkL8Wxzb+1ClEWq0Fzxk1BZU/YK2N4E0/WdTeE/KPwgNEOaD/IiP5e 7nSU7cIeaecKAZG7pPazOpeNWmHBsr1ptfFRbwrBWeV7m03ekf+gUHprpcXPkPucJ5kwwTmsnt8 dK0s6v0e40LcmHseFllDDp5Vob6318qQJbcYyGpMU6cEZncAmAwGvajRCtws365Eg X-Received: by 2002:a17:903:22c5:b0:2da:eba4:b640 with SMTP id d9443c01a7336-2db10518c67mr5531025ad.6.1788448895645; Thu, 03 Sep 2026 08:21:35 -0700 (PDT) X-Received: by 2002:a17:903:22c5:b0:2da:eba4:b640 with SMTP id d9443c01a7336-2db10518c67mr5530325ad.6.1788448895091; Thu, 03 Sep 2026 08:21:35 -0700 (PDT) Received: from [10.133.33.96] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2dafe62d8dcsm11883625ad.26.2026.09.03.08.21.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Sep 2026 08:21:33 -0700 (PDT) Message-ID: <75246b2d-4787-4748-831c-d66e3b42faa6@oss.qualcomm.com> Date: Thu, 3 Sep 2026 23:21:27 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 07/12] clk: qcom: ipq-cmn-pll: Add PON reference clock support To: Konrad Dybcio , Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, quic_kkumarcs@quicinc.com, quic_linchen@quicinc.com, quic_leiwei@quicinc.com, quic_suruchia@quicinc.com References: <20260814-qcom_ipq5210_cmnpll-v3-0-21c3db378611@oss.qualcomm.com> <20260814-qcom_ipq5210_cmnpll-v3-7-21c3db378611@oss.qualcomm.com> <7e32b791-b27a-4b0d-8143-ff4eadd11fa2@oss.qualcomm.com> Content-Language: en-US From: Jie Luo In-Reply-To: <7e32b791-b27a-4b0d-8143-ff4eadd11fa2@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTAzMDEzNCBTYWx0ZWRfX0yI/IZGkgkDn Nt6AyJQIeznTWB1xTnrPy4/WIUji0EHXD+Ml8xbTdW/W4VbL44QxiYBaOtlM4QD5z0a/ezTkisy 1LaTI0Uxs41/A6fINIRTvS12sgr+Ly6CDDmTdVByVjIEN7GyRmAJTGLQDftmBFGFuR6pIzdkiCi pzppoLocOi2UGnlnD+U8uRy5woOcl4yg22Rjk1jZBwnxbYq3YfCPXKqx7A2IrENp3R0gVrifdNb aCVVvjFEo67kpcL2bV/w//GMIw02oxeizg7/QcGxkZhjEf0hiHhQuRVWEVGHZSPlc3if6FB9Jx/ O+hCdNEdlrymd1p4ssDmPZnsGwEBogNHWQSIW7P4eWmrz/WFpIhFv14SVu1NE1BYN5cStFy0pdO qSjOlzEYbjiY7Wqzp1UVs3QsbOd/k3WiN2byR8dLrhv/XA8VNue2rPtPRQKpKd9nSdcquoXGBEG JlbCX9DJOz8QaXgN+OQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTAzMDEzNCBTYWx0ZWRfX96d0xaKTLDl6 YfpS6RXojyCh5XbIFUFMtvNcXfpdXwLWWgjJVmiL0CMcXK3kH24KVsWcHaUZ/DJAeDNVS0is6a7 iZHHcHt95EPV2x8+FbgUHehUufSR644= X-Proofpoint-GUID: 3WzsXR9cN32noczbS8fRZAsrvWOygaQX X-Proofpoint-ORIG-GUID: 3WzsXR9cN32noczbS8fRZAsrvWOygaQX X-Authority-Analysis: v=2.4 cv=LZ4MLDfi c=1 sm=1 tr=0 ts=6a999080 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=eyD6XQoqffRT7lHHdTUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-03_04,2026-09-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609030134 On 9/3/2026 7:57 PM, Konrad Dybcio wrote: > On 8/14/26 2:48 PM, Luo Jie wrote: >> The PON (Passive Optical Network) reference clock's parent is >> cmn_pll_div2 (CMN PLL rate / 2); it is then further divided by a >> configurable 8-bit divider (1-255). The clock supports two modes: > > [...] > >> +static const struct clk_ops clk_pon_clk_ops = { >> + .enable = clk_pon_clk_enable, > > clk_enable_regmap >> + .disable = clk_pon_clk_disable, > > clk_disable_regmap > >> + .is_enabled = clk_pon_clk_is_enabled, > > clk_is_enabled_regmap > >> + .recalc_rate = clk_pon_clk_recalc_rate, >> + .determine_rate = clk_pon_clk_determine_rate, >> + .set_rate = clk_pon_clk_set_rate, > > These seem genuinely new > > Konrad Thanks. I’ll fix this by converting the PON clock to struct clk_regmap, setting enable_reg and enable_mask, and using clk_enable_regmap, clk_disable_regmap, and clk_is_enabled_regmap for the corresponding operations. I’ll retain the custom recalc_rate, determine_rate, and set_rate implementations as suggested.