From: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
To: Xiaoliang Pang <dawning.pang@gmail.com>,
mchehab@kernel.org, sakari.ailus@linux.intel.com,
gregkh@linuxfoundation.org
Cc: alexander.deucher@amd.com, evan.quan@amd.com,
christian.koenig@amd.com, linux-media@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] atomisp:pci/runtime/queue: modify the return error value
Date: Thu, 17 Sep 2020 13:31:13 +0800 [thread overview]
Message-ID: <75262d3f-eeb6-5531-a93d-85376236774a@linux.alibaba.com> (raw)
In-Reply-To: <20200917034451.20897-1-dawning.pang@gmail.com>
LGTM.
Reviewed-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
On 9/17/20 11:44 AM, Xiaoliang Pang wrote:
> modify the return error value is -EDOM
>
> Fixes: 2cac05dee6e30("drm/amd/powerplay: add the hw manager for vega12 (v4)")
> Cc: Evan Quan <evan.quan@amd.com>
> Signed-off-by: Xiaoliang Pang <dawning.pang@gmail.com>
> ---
> .../staging/media/atomisp/pci/runtime/queue/src/queue_access.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue_access.c b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue_access.c
> index fdca743c4ab7..424e7a15a389 100644
> --- a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue_access.c
> +++ b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue_access.c
> @@ -44,7 +44,7 @@ int ia_css_queue_load(
> the value as zero. This causes division by 0
> exception as the size is used in a modular
> division operation. */
> - return EDOM;
> + return -EDOM;
> }
> }
>
>
prev parent reply other threads:[~2020-09-17 5:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 3:44 Xiaoliang Pang
2020-09-17 5:31 ` Tianjia Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75262d3f-eeb6-5531-a93d-85376236774a@linux.alibaba.com \
--to=tianjia.zhang@linux.alibaba.com \
--cc=alexander.deucher@amd.com \
--cc=christian.koenig@amd.com \
--cc=dawning.pang@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=evan.quan@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®