Re: [PATCH] staging: rtl8712: Fix unnecessary parentheses warnings

[Dan Carpenter <dan.carpenter@linaro.org>]

On Fri, Sep 27, 2024 at 03:36:42PM +0000, Xingquan Liu wrote:
> On Fri Sep 27, 2024 at 11:26 PM CST, Dan Carpenter wrote:
> > On Fri, Sep 27, 2024 at 11:16:36PM +0800, Xingquan Liu wrote:
> > > Fix all unnecessary parentheses warnings in checkpath.
> > >
> > > Signed-off-by: Xingquan Liu <b1n@b1n.io>
> > > ---
> > > I ran clang-format additionally because I noticed the Linux community
> > > recommends submitting code formatting patches along with other patches.
> > 
> > Probably avoid running clang-format.  If we wanted to do that, we could have
> > done it already.
> 
> Ok.
> 
> > >
> > > I'm not sure if there are any issues with this.
> > 
> > This patch does way too many things at once.  This is a long way away from being
> > something we would even look at.
> 
> I wanna fix all unnecessary parentheses warnings in one patch, is it ok?

Greg doesn't agree with checkpatch about unnecessary parentheses.  If the code
looks like this:

	if ((a == b) || (b == c)) {

then just ignore checkpatch.  However if the code looks like:

	p = &(foo);

Then change it to:

	p = &foo;

This sort of change would need to be split up by driver instead of all of
driver/staging.  So it would be a series of patches.  You don't need to split
it up by file.  Split it by driver.

regards,
dan carpenter