From: Qingwei Hu <qingwei.hu@bytedance.com>
To: Vivian Wang <wangruikang@iscas.ac.cn>
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
"Paul Walmsley" <pjw@kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Alexandre Ghiti" <alex@ghiti.fr>,
"Deepak Gupta" <debug@rivosinc.com>,
"Pincheng Wang" <pincheng.plct@isrc.iscas.ac.cn>,
"Chunyan Zhang" <zhangchunyan@iscas.ac.cn>,
"Hui Wang" <hui.wang@canonical.com>,
"Clément Léger" <cleger@rivosinc.com>,
"Xu Lu" <luxu.kernel@bytedance.com>,
"Guodong Xu" <guodong@riscstar.com>
Subject: Re: [PATCH v1] riscv: cpufeature: Add Zic64b ISA extension support
Date: Sat, 30 May 2026 11:36:11 +0800 [thread overview]
Message-ID: <752F28EA-9255-4DBE-8007-F57947305D71@bytedance.com> (raw)
In-Reply-To: <302dfaf7-4a38-408f-997e-68ed27de2341@iscas.ac.cn>
Hi Vivian,
Thanks for the feedback.
> On May 29, 2026, at 11:14, Vivian Wang <wangruikang@iscas.ac.cn> wrote:
>
> On 5/28/26 22:16, Qingwei Hu wrote:
>> Zic64b describes a platform with 64-byte cache block sizes. It is a
>> mandatory part of RVA23U64, but a system may provide 64-byte CMO block
>> sizes without satisfying all profile requirements.
>>
>> The ISA string parser currently ignores Zic64b because the extension is
>> not present in the cpufeature table. Add an ISA extension ID and table
>> entry for Zic64b so it can be reported in /proc/cpuinfo when firmware
>> advertises it.
>
> I'd like to understand: What is the motivation to doing this, given that
> the very same information is already available as riscv,cbo*-block-size
> and hwprobe?
The motivation here is not to replace riscv,cbo*-block-size or hwprobe.
Those are still the right interfaces for software that needs the actual
CBO block size.
This is more about preserving the ISA extension name reported by
firmware. Some platforms report zic64b in the ISA string, but Linux
currently drops it because there is no cpufeature entry, so cpuinfo no
longer matches what firmware advertised. That makes profile/ISA-string
comparison tools a bit awkward.
So the patch only makes zic64b visible as a named ISA extension when
firmware reports it, while still validating it against any CBO block
sizes that firmware provides.
> If an extension is what we want to go with, then
> Documentation/devicetree/bindings/riscv/extensions.yaml also needs
> updating to match.
And yes, if we keep this direction, I agree extensions.yaml should be
updated in v2.
Thanks,
Qingwei Hu
next prev parent reply other threads:[~2026-05-30 3:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 14:16 Qingwei Hu
2026-05-29 3:14 ` Vivian Wang
2026-05-30 3:36 ` Qingwei Hu [this message]
2026-05-30 23:09 ` Conor Dooley
2026-06-03 12:32 ` Qingwei Hu
2026-06-03 13:17 ` Conor Dooley
2026-06-03 15:22 ` [External] " Qingwei Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=752F28EA-9255-4DBE-8007-F57947305D71@bytedance.com \
--to=qingwei.hu@bytedance.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=cleger@rivosinc.com \
--cc=debug@rivosinc.com \
--cc=guodong@riscstar.com \
--cc=hui.wang@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=luxu.kernel@bytedance.com \
--cc=palmer@dabbelt.com \
--cc=pincheng.plct@isrc.iscas.ac.cn \
--cc=pjw@kernel.org \
--cc=wangruikang@iscas.ac.cn \
--cc=zhangchunyan@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®