From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5738C73C7F for ; Wed, 10 Jul 2019 07:32:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A7F8E20838 for ; Wed, 10 Jul 2019 07:32:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727361AbfGJHch (ORCPT ); Wed, 10 Jul 2019 03:32:37 -0400 Received: from mga11.intel.com ([192.55.52.93]:55878 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726141AbfGJHcg (ORCPT ); Wed, 10 Jul 2019 03:32:36 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2019 00:32:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,473,1557212400"; d="scan'208";a="249387164" Received: from liujing-mobl.ccr.corp.intel.com (HELO [10.238.129.20]) ([10.238.129.20]) by orsmga001.jf.intel.com with ESMTP; 10 Jul 2019 00:32:34 -0700 Subject: Re: [PATCH 2/5] KVM: cpuid: extract do_cpuid_7_mask and support multiple subleafs To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <20190704140715.31181-1-pbonzini@redhat.com> <20190704140715.31181-3-pbonzini@redhat.com> <5af77de6-3a18-a3b9-b492-c280ac4310a1@linux.intel.com> From: Jing Liu Message-ID: <752c2473-04d9-8420-a78f-fa677f806aca@linux.intel.com> Date: Wed, 10 Jul 2019 15:32:34 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/10/2019 2:30 PM, Paolo Bonzini wrote: > On 08/07/19 09:07, Jing Liu wrote: >>> >> And when adding subleaf 1, plan to add codes, >> >> case 1: >>     entry->eax |= kvm_cpuid_7_1_eax_x86_features; >>     entry->ebx = entry->ecx = entry->edx =0; >>     break; >> >> What do you think? > > This should be "&=", not "|=". Otherwise yes, that's the idea. > Yes! So let me send out the BFloat16 patch based on your patch set now or you have merge plan soon? Thanks, Jing > Paolo >