From: Ping-Ke Shih <pkshih@realtek.com>
To: Liang Jie <buaajxlj@163.com>
Cc: "kvalo@kernel.org" <kvalo@kernel.org>,
Bernie Huang <phhuang@realtek.com>,
"fanggeng@lixiang.com" <fanggeng@lixiang.com>,
"yangchen11@lixiang.com" <yangchen11@lixiang.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Liang Jie <liangjie@lixiang.com>
Subject: RE: [PATCH v2] wifi: rtw89: Correct immediate cfg_len calculation for scan_offload_be
Date: Thu, 9 Jan 2025 01:55:23 +0000 [thread overview]
Message-ID: <752e62938a254fef863eebdf4d85e759@realtek.com> (raw)
In-Reply-To: <20250109015032.1070045-1-buaajxlj@163.com>
Liang Jie <buaajxlj@163.com> wrote:
> diff --git a/drivers/net/wireless/realtek/rtw89/fw.c b/drivers/net/wireless/realtek/rtw89/fw.c
> index 2191c037d72e..2be1bee724ca 100644
> --- a/drivers/net/wireless/realtek/rtw89/fw.c
> +++ b/drivers/net/wireless/realtek/rtw89/fw.c
> @@ -5170,6 +5170,7 @@ int rtw89_fw_h2c_scan_offload_be(struct rtw89_dev *rtwdev,
> u8 opch_size = sizeof(*opch) * option->num_opch;
> u8 probe_id[NUM_NL80211_BANDS];
> u8 cfg_len = sizeof(*h2c);
> + u8 ver = U8_MAX;
> unsigned int cond;
> void *ptr;
> int ret;
In reverse X'mas tree. Otherwise, looks good to me.
next prev parent reply other threads:[~2025-01-09 1:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 1:50 Liang Jie
2025-01-09 1:55 ` Ping-Ke Shih [this message]
2025-01-09 2:11 ` Liang Jie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=752e62938a254fef863eebdf4d85e759@realtek.com \
--to=pkshih@realtek.com \
--cc=buaajxlj@163.com \
--cc=fanggeng@lixiang.com \
--cc=kvalo@kernel.org \
--cc=liangjie@lixiang.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=phhuang@realtek.com \
--cc=yangchen11@lixiang.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®