From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Andy Gross <agross@kernel.org>, Arnd Bergmann <arnd@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Doug Anderson <dianders@chromium.org>
Subject: Re: [PATCH] Revert "soc: qcom: stats: Add DDR sleep stats"
Date: Sat, 16 Dec 2023 14:07:38 +0100 [thread overview]
Message-ID: <7530d783-00e7-4196-b18f-3eb372df8325@linaro.org> (raw)
In-Reply-To: <cxrw3fc4jxd2zee655g4gi2eshqnwquhezcehnvwjuyt4qkihr@ganx5uwzc35r>
On 16.12.2023 05:35, Bjorn Andersson wrote:
> On Sat, Dec 16, 2023 at 01:05:53AM +0100, Konrad Dybcio wrote:
>> On 14.12.2023 13:25, Konrad Dybcio wrote:
>>> After recent reports ([1], [2]) of older platforms (particularly 8150 and
>>> 7180) breaking after DDR sleep stats introduction, revert the following:
>>>
>>> Commit 73380e2573c3 ("soc: qcom: stats: fix 64-bit division")
>>> Commit e84e61bdb97c ("soc: qcom: stats: Add DDR sleep stats")
>>>
>>> The feature itself is rather useful for debugging DRAM power management,
>>> however it looks like the shared RPMh stats data structures differ on
>>> previous SoCs.
>>>
>>> Revert its addition for now to un-break booting on these earlier SoCs,
>>> while I try to come up with a better way to enable it conditionally.
>>>
>>> [1] https://lore.kernel.org/linux-arm-msm/20231209215601.3543895-2-dmitry.baryshkov@linaro.org/
>>> [2] https://lore.kernel.org/linux-arm-msm/CAD=FV=XX4wLg1NNVL15RK4D4tLvuSzZyUv=k_tS4bSb3=7QJzQ@mail.gmail.com/
>>>
>>> Reported-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>>> Reported-by: Doug Anderson <dianders@chromium.org>
>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>> ---
>> Arnd, since Bjorn seems to be MIA, could you please pick this directly
>> so that it gets into the next RC? Un-breaking booting on some platforms
>> would be very welcome :D
>>
>
> I'm confused, the two offending commits are staged for v6.8. Which -rc
> do you want this applied in?! And you posted this patch yesterday...
Uh right, sorry, I should think twice before sending such emails late
into the night..
Konrad
next prev parent reply other threads:[~2023-12-16 13:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 12:25 Konrad Dybcio
2023-12-14 17:48 ` Doug Anderson
2023-12-16 0:05 ` Konrad Dybcio
2023-12-16 4:35 ` Bjorn Andersson
2023-12-16 13:07 ` Konrad Dybcio [this message]
2023-12-17 17:21 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7530d783-00e7-4196-b18f-3eb372df8325@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=arnd@kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®