From: Florian Fainelli <f.fainelli@gmail.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>,
Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Arun Ramadoss <arun.ramadoss@microchip.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v4 4/4] net: dsa: microchip: ksz8: add MTU configuration support
Date: Thu, 10 Nov 2022 06:43:50 -0800 [thread overview]
Message-ID: <75394de2-44ca-7a65-3dce-7c583b514e0a@gmail.com> (raw)
In-Reply-To: <20221110122225.1283326-5-o.rempel@pengutronix.de>
On 11/10/2022 4:22 AM, Oleksij Rempel wrote:
> Make MTU configurable on KSZ87xx and KSZ88xx series of switches.
>
> Before this patch, pre-configured behavior was different on different
> switch series, due to opposite meaning of the same bit:
> - KSZ87xx: Reg 4, Bit 1 - if 1, max frame size is 1532; if 0 - 1514
> - KSZ88xx: Reg 4, Bit 1 - if 1, max frame size is 1514; if 0 - 1532
>
> Since the code was telling "... SW_LEGAL_PACKET_DISABLE, true)", I
> assume, the idea was to set max frame size to 1532.
>
> With this patch, by setting MTU size 1500, both switch series will be
> configured to the 1532 frame limit.
>
> This patch was tested on KSZ8873.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> Acked-by: Arun Ramadoss <arun.ramadoss@microchip.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
prev parent reply other threads:[~2022-11-10 14:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 12:22 [PATCH net-next v4 0/4] net: dsa: microchip: add MTU support for KSZ8 series Oleksij Rempel
2022-11-10 12:22 ` [PATCH net-next v4 1/4] net: dsa: microchip: move max mtu to one location Oleksij Rempel
2022-11-10 14:42 ` Florian Fainelli
2022-11-11 5:26 ` Oleksij Rempel
2022-11-10 12:22 ` [PATCH net-next v4 2/4] net: dsa: microchip: do not store max MTU for all ports Oleksij Rempel
2022-11-10 13:04 ` Vladimir Oltean
2022-11-10 14:42 ` Florian Fainelli
2022-11-10 12:22 ` [PATCH net-next v4 3/4] net: dsa: microchip: add ksz_rmw8() function Oleksij Rempel
2022-11-10 14:42 ` Florian Fainelli
2022-11-10 12:22 ` [PATCH net-next v4 4/4] net: dsa: microchip: ksz8: add MTU configuration support Oleksij Rempel
2022-11-10 13:03 ` Vladimir Oltean
2022-11-11 5:29 ` Oleksij Rempel
2022-11-10 14:43 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75394de2-44ca-7a65-3dce-7c583b514e0a@gmail.com \
--to=f.fainelli@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=arun.ramadoss@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®