From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E461817A303 for ; Thu, 16 Jul 2026 04:58:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784177894; cv=none; b=qj6E9hzO/5g/gFBi2awQ2T7aR62HZfK1RL0tgkCr5TuEcTubOMcnO86HpJ0RnwniFSDKM6Nn1OZi4vxz4LzmGUnk0BmA0BP4M38gdDTrC1DninJtNR2VsDxNZA2Ocjh/QqGZBDNv4lD/KlvygwZvoesOW8n8fHWSdmQxWce/GWY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784177894; c=relaxed/simple; bh=SYalH9rl1ePq/L4GRF0qOaRCXOXJ+DRCh9UGt0m2Qrg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=M/e1kl8hRoIB8FS7OWF4icfybFouVJbZafPeGFnmCOHsJn4D8hnppGhUNQcVTzY6jKpNwEInDh8R55iKOv7zhjw39R3zK5e1FGTyAzPDRQwT9Obau75fzOZlWA7w6fMUhL0tC2mow/YqdAR5zsAsvq7lE60vuVYwP5nsYEQPZB0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=J8Q2KYKx; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=lqBkxIFQ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="J8Q2KYKx"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="lqBkxIFQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784177891; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B7oZHOBdSLZmv8DzC8nUn2BhOLEhw/y+oCq0Qrz3pQg=; b=J8Q2KYKxT3VSfLG8bN9i4EVbIrKmq00RacNtSdh6RVNCPogD+75piIFM3LnoRSalhaZaDs 3ORblcIKAu+QGrmjtPgvlaroUBKyJPaH92cBkwskvSFLhYRFKX5uYIuSNiZK/Qr5m3rQTM +9LGByPyNtOSVNGWIZegcVKpx/Nqj0g= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-134-zyOXMXgDO76hYTY6dADbgg-1; Thu, 16 Jul 2026 00:58:09 -0400 X-MC-Unique: zyOXMXgDO76hYTY6dADbgg-1 X-Mimecast-MFC-AGG-ID: zyOXMXgDO76hYTY6dADbgg_1784177888 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2cee1ec30f2so41679065ad.3 for ; Wed, 15 Jul 2026 21:58:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1784177888; x=1784782688; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=B7oZHOBdSLZmv8DzC8nUn2BhOLEhw/y+oCq0Qrz3pQg=; b=lqBkxIFQfmHE21TVN5YaxwDonUkDtNE0nyAUUtPSCEJOxnKr9SxdaYYqy2It6CL5LA jt8V2m5S+3iBtMz5xk8jvfBBmo8q9rClaeaD9iaUzie8YNzHf54Fyy/8IOItR6ZakFil CB9NwIEBLAB/PJlcgd5OZtK3qJGidcDiTetMbRF4afgQKQeX1ykzhEhoF+PmweXrXM9Z AK49bwUX4nez0RX2lmRpPlaWBcJQXIbkTqf9nByl/zY8an77QhbyIcg+0HTnHu1nRmKu +PtzXLW4sh2ccdDyCyQYGs5RG1NA66EGrI4HTigOIylUQsSv9ta/6Iuvo7NzXxRr1I6W bnkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784177888; x=1784782688; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=B7oZHOBdSLZmv8DzC8nUn2BhOLEhw/y+oCq0Qrz3pQg=; b=mcDbXcA1MBN9HgU5KSrXePZ3kn4WIA0Pv4Z9u8mOC7Rnyr5NX7xi8mdgQG/R6AI25y l+T9RPe70jA18BOvt7aHu/dDhMH1pK04QDrGdju3bue3AcmWFayyNTzcSk8yknIoJ2K9 3Sc75NQEMMI4PSmOwpT7jUqcKAG/O44+ATzn4wN/cWMwIJVlbfmDH8e7U1ze0f6yH6ho TsxJRUt9evJPAFo8f+cjiPt1JQyeKACgD0kAbE+yW3H462/T4qvv2BGBpcISJInTfkCo 8j00/ory08o1v9FVybbFA99zGeRo2hLysg3iHB8Zf7ap/6CDI92qeKUHUC0U/s4bvxki +9HA== X-Forwarded-Encrypted: i=1; AHgh+RpyTq47U/EIz2pFhQHvZ8bqqb4a56d4ku1yYieFggwfwbbmTUNqgIj6vDUsFH+1zsYwCaudmUgCVJdg/s0=@vger.kernel.org X-Gm-Message-State: AOJu0YyJkFYXou4mCLwQGMq6XNYiMTKWagrkYTU3CINTH1KxHRUGer9S e+NOBsd3/qom3cEgLM2Nvv6yny57r6Bp6qXsziU25MUIu0u6J6eLm7Ln0tXNRIdKueRjySsh1tA hrX2fObs1lZxwYdtMhVE2XYeaV+pXpZwg49oZjMCWEd/TJ0dDuQiyCiiiLA6j7i8c4w== X-Gm-Gg: AfdE7clGqI/VEWdEbTEbXPrP3SbqaADUf5BmhQXPH90rAENSYOKuSDNYSHyM/F9F3na +19W8GqXD/v6OKLR7zLi1y6iLSa60BMc2FnOp05FtxIpnVBa0ZJ5EkJbDAmwF/jC1PEqnnlLBWX 53ANR6gc3zK9LPfa/usLKXtUCRJuHfo/RwfTpE1/vzMSRCGEi6iRAC3fPSTEmpUVNcb5AYlyxsq DQiPFUAYa8T7poBJUWodnuRWlX2CLz1tdqrQgU2WTZqhYE8XItpDVKLuuUu8isBy8NyfeciyLIA 9k4I5RuJc4nMll7bSSflN59V6162ZqOxhqlZ4ZRTof2mEvfp3O5UlZuHzrrdVa10Iih2sY2Yixb GL+xlV99XchpW/g+ntSDX2gHzFFZJwB63o273VLwYjHc= X-Received: by 2002:a17:902:da2d:b0:2ca:be8:62d with SMTP id d9443c01a7336-2ce9f3a0083mr182851095ad.32.1784177888380; Wed, 15 Jul 2026 21:58:08 -0700 (PDT) X-Received: by 2002:a17:902:da2d:b0:2ca:be8:62d with SMTP id d9443c01a7336-2ce9f3a0083mr182850885ad.32.1784177887771; Wed, 15 Jul 2026 21:58:07 -0700 (PDT) Received: from [192.168.68.51] (n175-34-8-244.mrk21.qld.optusnet.com.au. [175.34.8.244]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf1072eacbsm13239025ad.80.2026.07.15.21.58.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jul 2026 21:58:06 -0700 (PDT) Message-ID: <75394e50-45da-4b53-b0d9-80d57395b1ab@redhat.com> Date: Thu, 16 Jul 2026 14:58:02 +1000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 00/11] arm_mpam: minor fixes at v7.2 To: Ben Horgan Cc: james.morse@arm.com, reinette.chatre@intel.com, fenghuay@nvidia.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dave.martin@arm.com, andre.przywara@arm.com References: <20260710115546.29644-1-ben.horgan@arm.com> Content-Language: en-US From: Gavin Shan In-Reply-To: <20260710115546.29644-1-ben.horgan@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/10/26 9:55 PM, Ben Horgan wrote: > This is a bunch of small fixes for hypothetical problems in the driver. They > were found by a mixture of messing around with a software model, inspection and > llm review. > > The first two patches ensure the error interrupt isn't accidentally disabled > when register state is lost. Patch 3 keeps the feature accounting correct but > has no functional change. Patches 4 to 7 fix mbwu save/restore but this is not > relied on as we plan to just use resctrl assigned counters and these are > unassigned when a domain goes offline. Also, MSC afffinity of a region smaller > than a resctrl domain has not been seen. Patch 8 makes read_mon_cdp_safe() > behaviour the same for cdp_enabled and not. Patch 9 fixes an infinite loop in > a system using all the PARTIDs which is much bigger than anything than anything > I've seen. Patch 10 stops some allocations failing on similiarly big systems. > > Based on v7.2-rc2 > > Ben Horgan (11): > arm_mpam: Move MPAMF_ECR write helpers to allow reuse > arm_mpam: Restore the error interrupt enable from mpam_cpu_online() > arm_mpam: Set mpam_feat_msmon_mbwu_31counter when there are bandwidth > counters > arm_mpam: Add missing mon_sel locking in MBWU restore > arm_mpam: Ensure MBWU counters are reset on restore > arm_mpam: Use __ris_msmon_read() for saving MBWU state > arm_mpam: Initialize all of struct mon_read in > mpam_restore_mbwu_state() > arm_mpam: resctrl: Correct check that existing class is L3 > arm_mpam: resctrl: Make read_mon_cdp_safe() self consistent > arm_mpam: Don't loop forever if there is the maximum possible amount > of PARTIDs > arm_mpam: Switch to kvzmalloc_objs() for allocation of component cfg > > drivers/resctrl/mpam_devices.c | 124 ++++++++++++++++++++------------- > drivers/resctrl/mpam_resctrl.c | 4 +- > 2 files changed, 76 insertions(+), 52 deletions(-) > Tested on NVidia's grace-hopper machine and looks good: (a) kunit_tests passed; (b) l3 cache partitioning and MBW (soft) limiting work as expected; (c) llc_occupancy monitor counter alters when workload is attached and running. Tested-by: Gavin Shan Thanks, Gavin