From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752165AbdFUVwV (ORCPT ); Wed, 21 Jun 2017 17:52:21 -0400 Received: from esa4.dell-outbound.iphmx.com ([68.232.149.214]:35277 "EHLO esa4.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751979AbdFUVwT (ORCPT ); Wed, 21 Jun 2017 17:52:19 -0400 From: X-LoopCount0: from 10.175.216.250 X-IronPort-AV: E=Sophos;i="5.39,370,1493701200"; d="scan'208";a="1123199485" To: CC: , , , , Subject: RE: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number Thread-Topic: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number Thread-Index: AQHS5d+kk/AocFU6lEu7pmrbLSyJ6aImB6YAgAGolACAAecPAIAGTgwQ Date: Wed, 21 Jun 2017 21:52:12 +0000 Message-ID: <753a822799094c44ade76a66b1e1036a@ausx13mpc120.AMER.DELL.COM> References: <1495886134-8276-1-git-send-email-pali.rohar@gmail.com> <20170615135902.GS5248@pali> <201706171834.36487@pali> In-Reply-To: <201706171834.36487@pali> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.242.75] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v5LLqamq018394 > -----Original Message----- > From: Pali Rohár [mailto:pali.rohar@gmail.com] > Sent: Saturday, June 17, 2017 11:35 AM > To: Limonciello, Mario > Cc: dvhart@infradead.org; andy@infradead.org; luto@kernel.org; platform-driver- > x86@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance > number > > On Friday 16 June 2017 18:33:54 Mario.Limonciello@dell.com wrote: > > > -----Original Message----- > > > From: Limonciello, Mario > > > Sent: Thursday, June 15, 2017 10:16 AM > > > To: 'Pali Rohár' ; Darren Hart > > > Cc: Andy Shevchenko ; > > > Andy Lutomirski ; > > > platform-driver-x86@vger.kernel.org; linux-kernel@vger.kernel.org > > > Subject: RE: [PATCH] RFC: platform/x86: wmi: Fix check for method > > > instance number > > > > > > > -----Original Message----- > > > > From: Pali Rohár [mailto:pali.rohar@gmail.com] > > > > Sent: Thursday, June 15, 2017 8:59 AM > > > > To: Limonciello, Mario ; Darren Hart > > > > > > > > Cc: Andy Shevchenko ; Andy Lutomirski > > > > > > ; > > > > > > > platform-driver-x86@vger.kernel.org; linux-kernel@vger.kernel.org > > > > Subject: Re: [PATCH] RFC: platform/x86: wmi: Fix check for method > > > > instance number > > > > > > > > Mario, are you able to check if instance number passed to > > > > wmi_evaluate_method in following dell WMI drivers is correct and > > > > should be really 1? > > > > > > > > I suspect that it should be zero, as instance number is indexed > > > > from zero. > > > > > > > > There is no comment in those dell WMI drivers why it is 1, nor > > > > what 1 means. > > > > > > > > Ideally it needs to be checked in ACPI byte code, MOF file and > > > > WDG dump. > > > > > > I think you're likely correct. I don't have a box that supports > > > alienware-wmi or dell-wmi-led.c handy at the current moment to > > > confirm this hypothesis though. I'll confirm this later. > > > > > > I didn't realize it was zero indexed when I wrote alienware-wmi, > > > and I'm guessing the author of dell-wmi-led didn't either. > > > > > > The reason it's probably working is the ACPI byte code isn't > > > actually checking the instance since most times _WDG will only > > > call out one instance. > > > > I confirmed you're correct. Switching instance over to 0 works > > properly on an ASM200 (supported by alienware-wmi). > > Can you check what is the value in the instance_count in _WDG? > Instance count is 1. Thanks,