From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 3A1F5C2FC14
	for <linux-kernel@archiver.kernel.org>; Thu, 17 Aug 2023 12:27:46 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1350843AbjHQM1P (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Thu, 17 Aug 2023 08:27:15 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54938 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1350900AbjHQM1L (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 17 Aug 2023 08:27:11 -0400
Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A251E271B;
        Thu, 17 Aug 2023 05:27:09 -0700 (PDT)
Received: from kwepemm600003.china.huawei.com (unknown [172.30.72.57])
        by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4RRPL83spWztSHK;
        Thu, 17 Aug 2023 20:23:28 +0800 (CST)
Received: from [10.67.111.205] (10.67.111.205) by
 kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.31; Thu, 17 Aug 2023 20:27:05 +0800
Subject: Re: [PATCH v5 3/7] perf record: Move setting dummy tracking before
 record__init_thread_masks()
From:   Yang Jihong <yangjihong1@huawei.com>
To:     Ian Rogers <irogers@google.com>
CC:     <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
        <mark.rutland@arm.com>, <alexander.shishkin@linux.intel.com>,
        <jolsa@kernel.org>, <namhyung@kernel.org>,
        <kan.liang@linux.intel.com>, <james.clark@arm.com>,
        <tmricht@linux.ibm.com>, <ak@linux.intel.com>,
        <anshuman.khandual@arm.com>, <linux-kernel@vger.kernel.org>,
        <linux-perf-users@vger.kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>
References: <20230804020741.99806-1-yangjihong1@huawei.com>
 <20230804020741.99806-4-yangjihong1@huawei.com>
 <b8741176-dc9c-1ddb-6bb5-85293f3c61f7@intel.com>
 <CAP-5=fV2u+HwxwuCmz0uSo_dvbFAwwjvK_QvkorB+qbtMnwtZg@mail.gmail.com>
 <29111bbc-61af-4452-bf73-c3b32221989f@huawei.com>
Message-ID: <753ead6a-3113-5e10-3249-09a33042b8f3@huawei.com>
Date:   Thu, 17 Aug 2023 20:27:05 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
MIME-Version: 1.0
In-Reply-To: <29111bbc-61af-4452-bf73-c3b32221989f@huawei.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.67.111.205]
X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To
 kwepemm600003.china.huawei.com (7.193.23.202)
X-CFilter-Loop: Reflected
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello,

On 2023/8/15 9:57, Yang Jihong wrote:
> Hello,
> 
> On 2023/8/15 4:29, Ian Rogers wrote:
>> On Thu, Aug 3, 2023 at 11:58 PM Adrian Hunter 
>> <adrian.hunter@intel.com> wrote:
>>>
>>> On 4/08/23 05:07, Yang Jihong wrote:
>>>> When dummy tracking go system wide, the mmap cpu mask is changed.
>>
>> As previously commented, can we improve the quality of the function
>> names and commit messages? This sentence is particularly difficult to
>> understand, I don't understand it.
> 
> OK. The commit messages will be modified. Please check whether the 
> following description is clear:
> 
> User space tasks can migrate between CPUs, so when tracing selected 
> CPUs, sideband for all CPUs is needed. In this case set the cpu map of 
> the evsel to all online CPUs. This may modify the original cpu map of 
> the evlist.
> Therefore, need to check whether the preceding scenario exists before 
> record__init_thread_masks().
> Dummy tracking has been set in record__open(), move it before 
> record__init_thread_masks() and add a helper for unified processing.
> 
Ian, do you have any questions about the commit message above? If it's 
okay, I'll send the next version as above.

Thanks,
Yang